update gyp for ARM builds to be more well defined.

update gyp for ARM builds to be more well defined.

R=mtklein@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10454

[mtklein, 2013-07-29 20:02:16]

https://codereview.chromium.org/21096005/diff/3001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/21096005/diff/3001/gyp/common_conditions.gypi...
gyp/common_conditions.gypi:168: [ 'skia_arch_type == "arm" and arm_version ==
7', {
Merge this back with below for now?  Otherwise we won't have -march=anything for
arm_version > 7.  Seems better to leave it as armv7-a until we increase it
further.

https://codereview.chromium.org/21096005/diff/3001/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.chromium.org/21096005/diff/3001/gyp/opts.gyp#newcode97
gyp/opts.gyp:97: [ '(skia_arch_type != "arm") or (skia_os == "ios")', {
Wouldn't the equivalent be, skia_arch_type == "arm" and arm_version < 7 ?

[djsollen, 2013-07-29 20:25:59]

https://codereview.chromium.org/21096005/diff/3001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/21096005/diff/3001/gyp/common_conditions.gypi...
gyp/common_conditions.gypi:168: [ 'skia_arch_type == "arm" and arm_version ==
7', {
On 2013/07/29 20:02:16, mtklein wrote:
> Merge this back with below for now?  Otherwise we won't have -march=anything
for
> arm_version > 7.  Seems better to leave it as armv7-a until we increase it
> further.

The reason I moved it out is that there is not always a guarantee that the next
version will be backwards compatible. In the case of v8 it should be fine so I
can move it back.

[mtklein, 2013-07-29 22:07:08]

lgtm

[commit-bot: I haz the power, 2013-07-31 12:42:13]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[djsollen, 2013-07-31 12:57:33]

Committed patchset #3 manually as r10454 (presubmit successful).