Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: gyp/common_conditions.gypi

Issue 21096005: update gyp for ARM builds to be more well defined. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # conditions used in both common.gypi and skia.gyp in chromium 1 # conditions used in both common.gypi and skia.gyp in chromium
2 # 2 #
3 { 3 {
4 'defines': [ 4 'defines': [
5 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)', 5 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)',
6 # 'SK_SUPPORT_HINTING_SCALE_FACTOR', 6 # 'SK_SUPPORT_HINTING_SCALE_FACTOR',
7 ], 7 ],
8 'conditions' : [ 8 'conditions' : [
9 [ 'skia_gpu == 1', 9 [ 'skia_gpu == 1',
10 { 10 {
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 'conditions': [ 143 'conditions': [
144 [ 'skia_warnings_as_errors', { 144 [ 'skia_warnings_as_errors', {
145 'cflags': [ 145 'cflags': [
146 '-Werror', 146 '-Werror',
147 ], 147 ],
148 }], 148 }],
149 [ 'skia_arch_type == "arm" and arm_thumb == 1', { 149 [ 'skia_arch_type == "arm" and arm_thumb == 1', {
150 'cflags': [ 150 'cflags': [
151 '-mthumb', 151 '-mthumb',
152 ], 152 ],
153 # The --fix-cortex-a8 switch enables a link-time workaround for
154 # an erratum in certain Cortex-A8 processors. The workaround is
155 # enabled by default if you target the ARM v7-A arch profile.
156 # It can be enabled otherwise by specifying --fix-cortex-a8, or
157 # disabled unconditionally by specifying --no-fix-cortex-a8.
158 #
159 # The erratum only affects Thumb-2 code.
160 'conditions': [
161 [ 'arm_version < 7', {
162 'ldflags': [
163 '-Wl,--fix-cortex-a8',
164 ],
165 }],
166 ],
153 }], 167 }],
154 [ 'skia_arch_type == "arm" and armv7 == 1', { 168 [ 'skia_arch_type == "arm" and arm_version >= 7', {
155 'variables': { 169 'cflags': [
156 'arm_neon_optional%': 0, 170 '-march=armv7-a',
157 },
158 'defines': [
159 '__ARM_ARCH__=7',
160 ], 171 ],
161 'cflags': [ 172 'ldflags': [
162 '-march=armv7-a', 173 '-march=armv7-a',
163 ], 174 ],
164 'conditions': [ 175 'conditions': [
165 [ 'arm_neon == 1', { 176 [ 'arm_neon == 1', {
166 'defines': [ 177 'defines': [
167 '__ARM_HAVE_NEON', 178 '__ARM_HAVE_NEON',
168 ], 179 ],
169 'cflags': [ 180 'cflags': [
170 '-mfpu=neon', 181 '-mfpu=neon',
171 ], 182 ],
172 'ldflags': [
173 '-march=armv7-a',
174 '-Wl,--fix-cortex-a8',
175 ],
176 }], 183 }],
177 [ 'arm_neon_optional == 1', { 184 [ 'arm_neon_optional == 1', {
178 'defines': [ 185 'defines': [
179 '__ARM_HAVE_OPTIONAL_NEON_SUPPORT', 186 '__ARM_HAVE_OPTIONAL_NEON_SUPPORT',
180 ], 187 ],
181 }], 188 }],
182 [ 'skia_os != "chromeos"', { 189 [ 'skia_os != "chromeos"', {
183 'cflags': [ 190 'cflags': [
184 '-mfloat-abi=softfp', 191 '-mfloat-abi=softfp',
185 ], 192 ],
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 'xcode_settings': { 478 'xcode_settings': {
472 'SYMROOT': '<(DEPTH)/xcodebuild', 479 'SYMROOT': '<(DEPTH)/xcodebuild',
473 }, 480 },
474 } 481 }
475 482
476 # Local Variables: 483 # Local Variables:
477 # tab-width:2 484 # tab-width:2
478 # indent-tabs-mode:nil 485 # indent-tabs-mode:nil
479 # End: 486 # End:
480 # vim: set expandtab tabstop=2 shiftwidth=2: 487 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698