update gyp for ARM builds to be more well defined.

gyp/common_conditions.gypi

 # conditions used in both common.gypi and skia.gyp in chromium
 #
 {
   'defines': [
     'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)',
 #    'SK_SUPPORT_HINTING_SCALE_FACTOR',
   ],
   'conditions' : [
     [ 'skia_gpu == 1',
       {
@@ skipping 132 matching lines @@
         'conditions': [
           [ 'skia_warnings_as_errors', {
             'cflags': [
               '-Werror',
             ],
           }],
           [ 'skia_arch_type == "arm" and arm_thumb == 1', {
             'cflags': [
               '-mthumb',
             ],
+            # The --fix-cortex-a8 switch enables a link-time workaround for
+            # an erratum in certain Cortex-A8 processors.  The workaround is
+            # enabled by default if you target the ARM v7-A arch profile.
+            # It can be enabled otherwise by specifying --fix-cortex-a8, or
+            # disabled unconditionally by specifying --no-fix-cortex-a8.
+            #
+            # The erratum only affects Thumb-2 code.
+            'conditions': [
+              [ 'arm_version < 7', {
+                'ldflags': [
+                  '-Wl,--fix-cortex-a8',
+                ],
+              }],
+            ],
           }],
-          [ 'skia_arch_type == "arm" and armv7 == 1', {
-            'variables': {
-              'arm_neon_optional%': 0,
-            },
-            'defines': [
-              '__ARM_ARCH__=7',
-            ],
+          [ 'skia_arch_type == "arm" and arm_version == 7', {

[mtklein, 2013/07/29 20:02:16]

Merge this back with below for now?  Otherwise we won't have -march=anything for
arm_version > 7.  Seems better to leave it as armv7-a until we increase it
further.

[djsollen, 2013/07/29 20:25:59]

The reason I moved it out is that there is not always a guarantee that the next
version will be backwards compatible. In the case of v8 it should be fine so I
can move it back.

             'cflags': [
               '-march=armv7-a',
             ],
+            'ldflags': [
+              '-march=armv7-a',
+            ],
+          }],
+          [ 'skia_arch_type == "arm" and arm_version >= 7', {
             'conditions': [
               [ 'arm_neon == 1', {
                 'defines': [
                   '__ARM_HAVE_NEON',
                 ],
                 'cflags': [
                   '-mfpu=neon',
                 ],
-                'ldflags': [
-                  '-march=armv7-a',
-                  '-Wl,--fix-cortex-a8',
-                ],
               }],
               [ 'arm_neon_optional == 1', {
                 'defines': [
                   '__ARM_HAVE_OPTIONAL_NEON_SUPPORT',
                 ],
               }],
               [ 'skia_os != "chromeos"', {
                 'cflags': [
                   '-mfloat-abi=softfp',
                 ],
@@ skipping 285 matching lines @@
   'xcode_settings': {
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: