Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: gyp/opts.gyp

Issue 21096005: update gyp for ARM builds to be more well defined. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « gyp/libwebp.gyp ('k') | platform_tools/android/bin/android_setup.sh » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'targets': [ 2 'targets': [
3 # Due to an unfortunate intersection of lameness between gcc and gyp, 3 # Due to an unfortunate intersection of lameness between gcc and gyp,
4 # we have to build the *_SSE2.cpp files in a separate target. The 4 # we have to build the *_SSE2.cpp files in a separate target. The
5 # gcc lameness is that, in order to compile SSE2 intrinsics code, it 5 # gcc lameness is that, in order to compile SSE2 intrinsics code, it
6 # must be passed the -msse2 flag. However, with this flag, it may 6 # must be passed the -msse2 flag. However, with this flag, it may
7 # emit SSE2 instructions even for scalar code, such as the CPUID 7 # emit SSE2 instructions even for scalar code, such as the CPUID
8 # test used to test for the presence of SSE2. So that, and all other 8 # test used to test for the presence of SSE2. So that, and all other
9 # code must be compiled *without* -msse2. The gyp lameness is that it 9 # code must be compiled *without* -msse2. The gyp lameness is that it
10 # does not allow file-specific CFLAGS, so we must create this extra 10 # does not allow file-specific CFLAGS, so we must create this extra
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 ], 49 ],
50 'sources': [ 50 'sources': [
51 '../src/opts/opts_check_SSE2.cpp', 51 '../src/opts/opts_check_SSE2.cpp',
52 '../src/opts/SkBitmapProcState_opts_SSE2.cpp', 52 '../src/opts/SkBitmapProcState_opts_SSE2.cpp',
53 '../src/opts/SkBitmapFilter_opts_SSE2.cpp', 53 '../src/opts/SkBitmapFilter_opts_SSE2.cpp',
54 '../src/opts/SkBlitRow_opts_SSE2.cpp', 54 '../src/opts/SkBlitRow_opts_SSE2.cpp',
55 '../src/opts/SkBlitRect_opts_SSE2.cpp', 55 '../src/opts/SkBlitRect_opts_SSE2.cpp',
56 '../src/opts/SkUtils_opts_SSE2.cpp', 56 '../src/opts/SkUtils_opts_SSE2.cpp',
57 ], 57 ],
58 }], 58 }],
59 [ 'skia_arch_type == "arm" and armv7 == 1', { 59 [ 'skia_arch_type == "arm" and arm_version >= 7', {
60 # The assembly uses the frame pointer register (r7 in Thumb/r11 in 60 # The assembly uses the frame pointer register (r7 in Thumb/r11 in
61 # ARM), the compiler doesn't like that. 61 # ARM), the compiler doesn't like that.
62 'cflags!': [ 62 'cflags!': [
63 '-fno-omit-frame-pointer', 63 '-fno-omit-frame-pointer',
64 '-mapcs-frame', 64 '-mapcs-frame',
65 '-mapcs', 65 '-mapcs',
66 ], 66 ],
67 'cflags': [ 67 'cflags': [
68 '-fomit-frame-pointer', 68 '-fomit-frame-pointer',
69 '-mno-apcs-frame', 69 '-mno-apcs-frame',
(...skipping 17 matching lines...) Expand all
87 [ 'skia_os == "ios"', { 87 [ 'skia_os == "ios"', {
88 'sources!': [ 88 'sources!': [
89 # these fail to compile under xcode for ios 89 # these fail to compile under xcode for ios
90 '../src/opts/memset.arm.S', 90 '../src/opts/memset.arm.S',
91 '../src/opts/SkBitmapProcState_opts_arm.cpp', 91 '../src/opts/SkBitmapProcState_opts_arm.cpp',
92 '../src/opts/SkBlitRow_opts_arm.cpp', 92 '../src/opts/SkBlitRow_opts_arm.cpp',
93 ], 93 ],
94 }], 94 }],
95 ], 95 ],
96 }], 96 }],
97 [ '(skia_arch_type == "arm" and armv7 == 0) or (skia_os == "ios")', { 97 [ '(skia_arch_type == "arm" and arm_version < 7) or (skia_os == "ios")', {
98 'sources': [ 98 'sources': [
99 '../src/opts/SkBitmapProcState_opts_none.cpp', 99 '../src/opts/SkBitmapProcState_opts_none.cpp',
100 '../src/opts/SkBlitRow_opts_none.cpp', 100 '../src/opts/SkBlitRow_opts_none.cpp',
101 '../src/opts/SkUtils_opts_none.cpp', 101 '../src/opts/SkUtils_opts_none.cpp',
102 ], 102 ],
103 }], 103 }],
104 ], 104 ],
105 }, 105 },
106 # For the same lame reasons as what is done for skia_opts, we have to 106 # For the same lame reasons as what is done for skia_opts, we have to
107 # create another target specifically for SSSE3 code as we would not want 107 # create another target specifically for SSSE3 code as we would not want
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 ], 180 ],
181 }, 181 },
182 ], 182 ],
183 } 183 }
184 184
185 # Local Variables: 185 # Local Variables:
186 # tab-width:2 186 # tab-width:2
187 # indent-tabs-mode:nil 187 # indent-tabs-mode:nil
188 # End: 188 # End:
189 # vim: set expandtab tabstop=2 shiftwidth=2: 189 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « gyp/libwebp.gyp ('k') | platform_tools/android/bin/android_setup.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698