Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2106503002: Revert of cc: Add mailbox support to ResourceProvider write locks. (Closed)

Created:
4 years, 5 months ago by sunnyps
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, posciak+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@worker_context_sync_tokens_revert
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Add mailbox support to ResourceProvider write locks. (patchset #5 id:70001 of https://codereview.chromium.org/2081883002/ ) Reason for revert: Causing canvas crashes - bug 623101 Original issue's description: > Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ ) > > Original issue's description: > > cc: Add mailbox support to ResourceProvider write locks. > > > > This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox > > requires using ScopedTextureProvider/ScopedSkSurfaceProvider which > > ensures that the texture id for the mailbox is destroyed after use on > > the worker context. > > > > This CL also includes the following cleanup: > > 1. ResourceProvider locks don't keep resource pointers around. > > 2. ScopedSamplerGL does not inherit from ScopedReadLockGL. > > 3. GpuRasterizer is folded back into GpuRasterBufferProvider. > > 4. TileTaskManager does not own RasterBufferProvider. > > > > BUG=525259 > > R=piman@chromium.org > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > > > Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2 > > Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29 > > Cr-Original-Commit-Position: refs/heads/master@{#398204} > > Cr-Commit-Position: refs/heads/master@{#399983} > > R=piman@chromium.org > BUG=525259, 621422, 621130 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965 > Cr-Commit-Position: refs/heads/master@{#401717} TBR=piman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=525259, 621422, 621130 Committed: https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194 Cr-Commit-Position: refs/heads/master@{#402290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+689 lines, -812 lines) Patch
M cc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.h View 3 chunks +4 lines, -54 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 4 chunks +67 lines, -165 lines 0 comments Download
A cc/raster/gpu_rasterizer.h View 1 chunk +57 lines, -0 lines 0 comments Download
A cc/raster/gpu_rasterizer.cc View 1 chunk +86 lines, -0 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.h View 6 chunks +4 lines, -44 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.cc View 9 chunks +142 lines, -172 lines 0 comments Download
M cc/raster/raster_buffer_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/raster_buffer_provider_perftest.cc View 10 chunks +18 lines, -31 lines 0 comments Download
M cc/raster/raster_buffer_provider_unittest.cc View 7 chunks +18 lines, -17 lines 0 comments Download
M cc/resources/resource_provider.h View 5 chunks +49 lines, -71 lines 0 comments Download
M cc/resources/resource_provider.cc View 14 chunks +147 lines, -190 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M cc/test/fake_tile_task_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/test/fake_tile_task_manager.cc View 2 chunks +11 lines, -1 line 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/tiles/tile_manager.h View 4 chunks +2 lines, -6 lines 0 comments Download
M cc/tiles/tile_manager.cc View 9 chunks +13 lines, -22 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M cc/tiles/tile_task_manager.h View 2 chunks +9 lines, -1 line 0 comments Download
M cc/tiles/tile_task_manager.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sunnyps
Created Revert of cc: Add mailbox support to ResourceProvider write locks.
4 years, 5 months ago (2016-06-27 20:06:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106503002/1
4 years, 5 months ago (2016-06-27 20:07:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 21:34:38 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194 Cr-Commit-Position: refs/heads/master@{#402290}
4 years, 5 months ago (2016-06-27 21:36:02 UTC) #6
sunnyps
4 years, 5 months ago (2016-06-27 21:38:56 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2101043002/ by sunnyps@chromium.org.

The reason for reverting is: Reland.

Powered by Google App Engine
This is Rietveld 408576698