Reland of cc: Add mailbox support to ResourceProvider write locks.

Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ )

Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG=525259
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

R=piman@chromium.org
BUG=525259, 621422, 621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965
Cr-Commit-Position: refs/heads/master@{#401717}

[sunnyps, 2016-06-21 01:21:09]

Tasks aren't cancelled on invalid sync token, instead the tasks early out while
running.

PTAL

[piman, 2016-06-21 01:45:35]

https://codereview.chromium.org/2081883002/diff/20001/cc/raster/gpu_raster_bu...
File cc/raster/gpu_raster_buffer_provider.cc (right):

https://codereview.chromium.org/2081883002/diff/20001/cc/raster/gpu_raster_bu...
cc/raster/gpu_raster_buffer_provider.cc:198:
DCHECK(gl->GetGraphicsResetStatusKHR() != GL_NO_ERROR);
Because they're not in the same share group, it's possible that this context
doesn't yet know that it's lost, so this DCHECK may not be right.

https://codereview.chromium.org/2081883002/diff/20001/cc/raster/one_copy_rast...
File cc/raster/one_copy_raster_buffer_provider.cc (right):

https://codereview.chromium.org/2081883002/diff/20001/cc/raster/one_copy_rast...
cc/raster/one_copy_raster_buffer_provider.cc:171: DCHECK(gl &&
gl->GetGraphicsResetStatusKHR() != GL_NO_ERROR);
ditto

[sunnyps, 2016-06-21 01:57:39]

PTAL

https://codereview.chromium.org/2081883002/diff/20001/cc/raster/gpu_raster_bu...
File cc/raster/gpu_raster_buffer_provider.cc (right):

https://codereview.chromium.org/2081883002/diff/20001/cc/raster/gpu_raster_bu...
cc/raster/gpu_raster_buffer_provider.cc:198:
DCHECK(gl->GetGraphicsResetStatusKHR() != GL_NO_ERROR);
On 2016/06/21 01:45:35, piman wrote:
> Because they're not in the same share group, it's possible that this context
> doesn't yet know that it's lost, so this DCHECK may not be right.

Removed the DCHECK.

https://codereview.chromium.org/2081883002/diff/20001/cc/raster/one_copy_rast...
File cc/raster/one_copy_raster_buffer_provider.cc (right):

https://codereview.chromium.org/2081883002/diff/20001/cc/raster/one_copy_rast...
cc/raster/one_copy_raster_buffer_provider.cc:171: DCHECK(gl &&
gl->GetGraphicsResetStatusKHR() != GL_NO_ERROR);
On 2016/06/21 01:45:35, piman wrote:
> ditto

Done.

[piman, 2016-06-21 02:06:36]

lgtm

[sunnyps, 2016-06-21 02:07:33]

Thanks! I'll wait for the next dev release before submitting this.

[sunnyps, 2016-06-22 22:43:40]

Description was changed from

==========
Reland of cc: Add mailbox support to ResourceProvider write locks.

Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG=525259
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

R=piman@chromium.org
BUG=525259, 621422, 621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24
id:460001 of https://codereview.chromium.org/1951193002/ )

Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG=525259
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

R=piman@chromium.org
BUG=525259, 621422, 621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunnyps, 2016-06-22 22:46:08]

I've removed insert/wait sync token for the non-async case so that we don't
regress idle wakeups for now.

PTAL

[piman, 2016-06-22 22:54:24]

lgtm

[sunnyps, 2016-06-22 22:54:49]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2016-06-22 22:55:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081883002/50001

[commit-bot: I haz the power, 2016-06-22 22:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 22:59:09]

Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sunnyps, 2016-06-23 20:12:47]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2016-06-23 20:12:48]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2081883002/#ps70001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-23 20:13:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081883002/70001

[commit-bot: I haz the power, 2016-06-23 21:21:41]

Description was changed from

==========
Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24
id:460001 of https://codereview.chromium.org/1951193002/ )

Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG=525259
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

R=piman@chromium.org
BUG=525259, 621422, 621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24
id:460001 of https://codereview.chromium.org/1951193002/ )

Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG=525259
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

R=piman@chromium.org
BUG=525259, 621422, 621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-23 21:21:43]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-06-23 21:24:06]

Description was changed from

==========
Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24
id:460001 of https://codereview.chromium.org/1951193002/ )

Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG=525259
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

R=piman@chromium.org
BUG=525259, 621422, 621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24
id:460001 of https://codereview.chromium.org/1951193002/ )

Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG=525259
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29
> Cr-Original-Commit-Position: refs/heads/master@{#398204}
> Cr-Commit-Position: refs/heads/master@{#399983}

R=piman@chromium.org
BUG=525259, 621422, 621130
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965
Cr-Commit-Position: refs/heads/master@{#401717}
==========

[commit-bot: I haz the power, 2016-06-23 21:24:07]

Patchset 5 (id:??) landed as
https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965
Cr-Commit-Position: refs/heads/master@{#401717}

[sunnyps, 2016-06-27 20:06:37]

A revert of this CL (patchset #5 id:70001) has been created in
https://codereview.chromium.org/2106503002/ by sunnyps@chromium.org.

The reason for reverting is: Causing canvas crashes - bug 623101.