Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2101043002: Reland of cc: Add mailbox support to ResourceProvider write locks. (Closed)

Created:
4 years, 5 months ago by sunnyps
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, posciak+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@worker_context_sync_tokens_revert
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #1 id:1 of https://codereview.chromium.org/2106503002/ ) Original issue's description: > Revert of cc: Add mailbox support to ResourceProvider write locks. (patchset #5 id:70001 of https://codereview.chromium.org/2081883002/ ) > > Reason for revert: > Causing canvas crashes - bug 623101 > > Original issue's description: > > Reland of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ ) > > > > Original issue's description: > > > cc: Add mailbox support to ResourceProvider write locks. > > > > > > This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox > > > requires using ScopedTextureProvider/ScopedSkSurfaceProvider which > > > ensures that the texture id for the mailbox is destroyed after use on > > > the worker context. > > > > > > This CL also includes the following cleanup: > > > 1. ResourceProvider locks don't keep resource pointers around. > > > 2. ScopedSamplerGL does not inherit from ScopedReadLockGL. > > > 3. GpuRasterizer is folded back into GpuRasterBufferProvider. > > > 4. TileTaskManager does not own RasterBufferProvider. > > > > > > BUG=525259 > > > R=piman@chromium.org > > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > > > > > Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2 > > > Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29 > > > Cr-Original-Commit-Position: refs/heads/master@{#398204} > > > Cr-Commit-Position: refs/heads/master@{#399983} > > > > R=piman@chromium.org > > BUG=525259, 621422, 621130 > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > > > Committed: https://crrev.com/b3071e4aabd0cb1f29cd624e77eb5f40722be965 > > Cr-Commit-Position: refs/heads/master@{#401717} > > TBR=piman@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=525259, 621422, 621130 > > Committed: https://crrev.com/4d27a5a3c38c34bfa34e9937ef8e3ea3831d2194 > Cr-Commit-Position: refs/heads/master@{#402290} TBR=piman@chromium.org BUG=525259, 621422, 621130 Committed: https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935 Cr-Commit-Position: refs/heads/master@{#402345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+821 lines, -698 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/gl_renderer.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.h View 3 chunks +54 lines, -4 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 4 chunks +170 lines, -72 lines 0 comments Download
D cc/raster/gpu_rasterizer.h View 1 chunk +0 lines, -57 lines 0 comments Download
D cc/raster/gpu_rasterizer.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.h View 6 chunks +44 lines, -4 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.cc View 9 chunks +172 lines, -142 lines 0 comments Download
M cc/raster/raster_buffer_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/raster_buffer_provider_perftest.cc View 10 chunks +31 lines, -18 lines 0 comments Download
M cc/raster/raster_buffer_provider_unittest.cc View 7 chunks +17 lines, -18 lines 0 comments Download
M cc/resources/resource_provider.h View 5 chunks +71 lines, -49 lines 0 comments Download
M cc/resources/resource_provider.cc View 14 chunks +192 lines, -149 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M cc/test/fake_tile_task_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/test/fake_tile_task_manager.cc View 2 chunks +1 line, -11 lines 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M cc/tiles/tile_manager.h View 4 chunks +6 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager.cc View 9 chunks +24 lines, -15 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 2 chunks +7 lines, -12 lines 0 comments Download
M cc/tiles/tile_task_manager.h View 2 chunks +1 line, -9 lines 0 comments Download
M cc/tiles/tile_task_manager.cc View 2 chunks +4 lines, -16 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
sunnyps
Created Reland of cc: Add mailbox support to ResourceProvider write locks.
4 years, 5 months ago (2016-06-27 21:38:56 UTC) #1
sunnyps
So it turns out that this CL was not responsible for the WebExternalTextureLayerImpl crash so ...
4 years, 5 months ago (2016-06-27 22:53:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101043002/1
4 years, 5 months ago (2016-06-27 22:55:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 00:40:25 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 00:42:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d6ff0d0e4c450cfb12aef3b455f63d380731935
Cr-Commit-Position: refs/heads/master@{#402345}

Powered by Google App Engine
This is Rietveld 408576698