Fix dependencies rules for create_bundle and bundle_data ninja steps.

Fix dependencies rules for create_bundle and bundle_data ninja steps.

Record the "bundle_data" target corresponding to a BundleFileRule object
so that the dependencies can be correctly computed when generating the
ninja steps for the "create_bundle" target.

Change the "stamp" step of "bundle_data" target in the generated ninja
to depends on the target dependencies and source files.

Change the "copy_bundle_data" steps of "create_bundle" target in the
generated ninja to depends on the "bundle_data" target that defined
the corresponding source files.

Change the "compile_xcassets" step of "create_bundle" target in the
generated ninja to depends on all the "bundle_data" targets that defined
the corresponding source files.

Change the rule used to determine whether a "bundle_data" source file
is part of an assets catalog (some file where incorrectly omitted causing
them to be incorrectly copied to the final bundle).

All those changes will allow the "copy_bundle_data" and "compile_xcassets"
steps to only depends on the targets that generate them (if any) and will
reduce the number of file copied into the final bundle during incremental
builds.

Fix unit tests with new expectations.

BUG=623501
Committed: https://crrev.com/4c75ba4852a79bde5ce03ebff7065282c9fd8977
Cr-Commit-Position: refs/heads/master@{#403304}

[sdefresne, 2016-06-28 15:25:11]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2016-06-28 15:25:12]

Please take a look and send to CQ if LGTY.

[sdefresne, 2016-06-29 07:59:03]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org

[sdefresne, 2016-06-29 07:59:04]

Dirk can you take a first look as Brett seems super busy?

[brettw, 2016-06-30 21:08:54]

I did a pretty cursory review and LGTM from that perspective.

[Dirk Pranke, 2016-06-30 21:17:12]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-06-30 21:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 21:59:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 21:59:39]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 22:01:23]

Description was changed from

==========
Fix dependencies rules for create_bundle and bundle_data ninja steps.

Record the "bundle_data" target corresponding to a BundleFileRule object
so that the dependencies can be correctly computed when generating the
ninja steps for the "create_bundle" target.

Change the "stamp" step of "bundle_data" target in the generated ninja
to depends on the target dependencies and source files.

Change the "copy_bundle_data" steps of "create_bundle" target in the
generated ninja to depends on the "bundle_data" target that defined
the corresponding source files.

Change the "compile_xcassets" step of "create_bundle" target in the
generated ninja to depends on all the "bundle_data" targets that defined
the corresponding source files.

Change the rule used to determine whether a "bundle_data" source file
is part of an assets catalog (some file where incorrectly omitted causing
them to be incorrectly copied to the final bundle).

All those changes will allow the "copy_bundle_data" and "compile_xcassets"
steps to only depends on the targets that generate them (if any) and will
reduce the number of file copied into the final bundle during incremental
builds.

Fix unit tests with new expectations.

BUG=623501
==========

to

==========
Fix dependencies rules for create_bundle and bundle_data ninja steps.

Record the "bundle_data" target corresponding to a BundleFileRule object
so that the dependencies can be correctly computed when generating the
ninja steps for the "create_bundle" target.

Change the "stamp" step of "bundle_data" target in the generated ninja
to depends on the target dependencies and source files.

Change the "copy_bundle_data" steps of "create_bundle" target in the
generated ninja to depends on the "bundle_data" target that defined
the corresponding source files.

Change the "compile_xcassets" step of "create_bundle" target in the
generated ninja to depends on all the "bundle_data" targets that defined
the corresponding source files.

Change the rule used to determine whether a "bundle_data" source file
is part of an assets catalog (some file where incorrectly omitted causing
them to be incorrectly copied to the final bundle).

All those changes will allow the "copy_bundle_data" and "compile_xcassets"
steps to only depends on the targets that generate them (if any) and will
reduce the number of file copied into the final bundle during incremental
builds.

Fix unit tests with new expectations.

BUG=623501

Committed: https://crrev.com/4c75ba4852a79bde5ce03ebff7065282c9fd8977
Cr-Commit-Position: refs/heads/master@{#403304}
==========

[commit-bot: I haz the power, 2016-06-30 22:01:25]

Patchset 2 (id:??) landed as
https://crrev.com/4c75ba4852a79bde5ce03ebff7065282c9fd8977
Cr-Commit-Position: refs/heads/master@{#403304}