Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: tools/gn/ninja_create_bundle_target_writer.h

Issue 2105613003: Fix dependencies rules for create_bundle and bundle_data ninja steps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove stamps (to allow using hardlinks) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_bundle_data_target_writer_unittest.cc ('k') | tools/gn/ninja_create_bundle_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_create_bundle_target_writer.h
diff --git a/tools/gn/ninja_create_bundle_target_writer.h b/tools/gn/ninja_create_bundle_target_writer.h
index 7c4239c05f8095ed4467aeb83dd3b70a7b993c86..824e7d95f969e9426737676864a6b98b40608358 100644
--- a/tools/gn/ninja_create_bundle_target_writer.h
+++ b/tools/gn/ninja_create_bundle_target_writer.h
@@ -8,6 +8,8 @@
#include "base/macros.h"
#include "tools/gn/ninja_target_writer.h"
+class BundleFileRule;
+
// Writes a .ninja file for a bundle_data target type.
class NinjaCreateBundleTargetWriter : public NinjaTargetWriter {
public:
@@ -23,33 +25,37 @@ class NinjaCreateBundleTargetWriter : public NinjaTargetWriter {
// defined, otherwise returns an empty string.
std::string WriteCodeSigningRuleDefinition();
- // Writes the rule to copy files into the bundle.
+ // Writes the steps to copy files into the bundle.
+ //
+ // The list of newly created files will be added to |output_files|.
+ void WriteCopyBundleDataSteps(std::vector<OutputFile>* output_files);
+
+ // Writes the step to copy files BundleFileRule into the bundle.
//
- // input_dep is a file expressing the shared dependencies. It will be a
- // stamp file if there is more than one.
- void WriteCopyBundleDataRules(const OutputFile& input_dep,
- std::vector<OutputFile>* output_files);
+ // The list of newly created files will be added to |output_files|.
+ void WriteCopyBundleFileRuleSteps(const BundleFileRule& file_rule,
+ std::vector<OutputFile>* output_files);
- // Writes the rule to compile assets catalogs.
+ // Writes the step to compile assets catalogs.
//
- // input_dep is a file expressing the shared dependencies. It will be a
- // stamp file if there is more than one.
- void WriteCompileAssetsCatalogRule(const OutputFile& input_dep,
- std::vector<OutputFile>* output_files);
+ // The list of newly created files will be added to |output_files|.
+ void WriteCompileAssetsCatalogStep(std::vector<OutputFile>* output_files);
+
+ // Writes the stamp file for the assets catalog compilation input
+ // dependencies.
+ OutputFile WriteCompileAssetsCatalogInputDepsStamp(
+ const std::vector<const Target*>& dependencies);
- // Writes the code signing rule (if a script is defined).
+ // Writes the code signing step (if a script is defined).
//
- // input_dep is a file expressing the shared dependencies. It will be a
- // stamp file if there is more than one. As the code signing may include
- // a manifest of the file, this will depends on all files in output_files
- // too.
- void WriteCodeSigningRules(const std::string& code_signing_rule_name,
- const OutputFile& input_dep,
- std::vector<OutputFile>* output_files);
+ // The list of newly created files will be added to |output_files|. As the
+ // code signing may depends on the full bundle structure, this step will
+ // depends on all files generated via other rules.
+ void WriteCodeSigningStep(const std::string& code_signing_rule_name,
+ std::vector<OutputFile>* output_files);
// Writes the stamp file for the code signing input dependencies.
OutputFile WriteCodeSigningInputDepsStamp(
- const OutputFile& input_dep,
std::vector<OutputFile>* output_files);
DISALLOW_COPY_AND_ASSIGN(NinjaCreateBundleTargetWriter);
« no previous file with comments | « tools/gn/ninja_bundle_data_target_writer_unittest.cc ('k') | tools/gn/ninja_create_bundle_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698