Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: tools/gn/bundle_file_rule.cc

Issue 2105613003: Fix dependencies rules for create_bundle and bundle_data ninja steps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove stamps (to allow using hardlinks) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/bundle_file_rule.h ('k') | tools/gn/gn.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/bundle_file_rule.cc
diff --git a/tools/gn/bundle_file_rule.cc b/tools/gn/bundle_file_rule.cc
index 9f78667779dd87de3821d7d12240e5a23d6c4fdd..e23361fbc5843ef8407439b613f9145c64033ec7 100644
--- a/tools/gn/bundle_file_rule.cc
+++ b/tools/gn/bundle_file_rule.cc
@@ -10,9 +10,13 @@
#include "tools/gn/substitution_writer.h"
#include "tools/gn/target.h"
-BundleFileRule::BundleFileRule(const std::vector<SourceFile> sources,
+BundleFileRule::BundleFileRule(const Target* bundle_data_target,
+ const std::vector<SourceFile> sources,
const SubstitutionPattern& pattern)
- : sources_(sources), pattern_(pattern) {}
+ : target_(bundle_data_target), sources_(sources), pattern_(pattern) {
+ // target_ may be null during testing.
+ DCHECK(!target_ || target_->output_type() == Target::BUNDLE_DATA);
+}
BundleFileRule::BundleFileRule(const BundleFileRule& other) = default;
« no previous file with comments | « tools/gn/bundle_file_rule.h ('k') | tools/gn/gn.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698