Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: tools/gn/bundle_file_rule.h

Issue 2105613003: Fix dependencies rules for create_bundle and bundle_data ninja steps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove stamps (to allow using hardlinks) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/bundle_data.cc ('k') | tools/gn/bundle_file_rule.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/bundle_file_rule.h
diff --git a/tools/gn/bundle_file_rule.h b/tools/gn/bundle_file_rule.h
index 9fbf01214d4cc34004fa194674c02e478649b8ca..372e62802c7d733d377877ffd6119b828084f1b4 100644
--- a/tools/gn/bundle_file_rule.h
+++ b/tools/gn/bundle_file_rule.h
@@ -13,12 +13,14 @@
class BundleData;
class Settings;
class SourceFile;
+class Target;
class OutputFile;
// BundleFileRule contains the information found in a "bundle_data" target.
class BundleFileRule {
public:
- BundleFileRule(const std::vector<SourceFile> sources,
+ BundleFileRule(const Target* bundle_data_target,
+ const std::vector<SourceFile> sources,
const SubstitutionPattern& pattern);
BundleFileRule(const BundleFileRule& other);
~BundleFileRule();
@@ -33,10 +35,15 @@ class BundleFileRule {
const BundleData& bundle_data,
const SourceFile& source_file) const;
+ // Returns the associated target (of type Target::BUNDLE_DATA). May be
+ // null during testing.
+ const Target* target() const { return target_; }
+
// Returns the list of SourceFiles.
const std::vector<SourceFile>& sources() const { return sources_; }
private:
+ const Target* target_;
std::vector<SourceFile> sources_;
SubstitutionPattern pattern_;
};
« no previous file with comments | « tools/gn/bundle_data.cc ('k') | tools/gn/bundle_file_rule.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698