content/renderer/fetchers/resource_fetcher_impl.cc - Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/fetchers/resource_fetcher_impl.cc

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments explaing why skip is set to ::Controlling for fallback requests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/service_worker/service_worker_types.h ('K') | « content/renderer/fetchers/resource_fetcher_impl.h ('k') | content/renderer/pepper/pepper_url_loader_host.cc » ('j') | third_party/WebKit/Source/platform/network/ResourceRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/fetchers/resource_fetcher_impl.cc

diff --git a/content/renderer/fetchers/resource_fetcher_impl.cc b/content/renderer/fetchers/resource_fetcher_impl.cc

index fa58f999c84b653d5f6255cfe297f0068f43d0ab..51878491e6a3403494189701d3ba69008ed89fe2 100644

--- a/content/renderer/fetchers/resource_fetcher_impl.cc

+++ b/content/renderer/fetchers/resource_fetcher_impl.cc

@@ -69,7 +69,8 @@ void ResourceFetcherImpl::SetHeader(const std::string& header,

}

-void ResourceFetcherImpl::SetSkipServiceWorker(bool skip_service_worker) {

+void ResourceFetcherImpl::SetSkipServiceWorker(

+ blink::WebURLRequest::SkipServiceWorker skip_service_worker) {

DCHECK(!request_.isNull());

DCHECK(!loader_);