Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: content/renderer/fetchers/resource_fetcher_impl.cc

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments explaing why skip is set to ::Controlling for fallback requests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/fetchers/resource_fetcher_impl.h" 5 #include "content/renderer/fetchers/resource_fetcher_impl.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "third_party/WebKit/public/platform/Platform.h" 10 #include "third_party/WebKit/public/platform/Platform.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 blink::WebReferrerPolicyDefault, 62 blink::WebReferrerPolicyDefault,
63 request_.url(), 63 request_.url(),
64 blink::WebString::fromUTF8(value)); 64 blink::WebString::fromUTF8(value));
65 request_.setHTTPReferrer(referrer, blink::WebReferrerPolicyDefault); 65 request_.setHTTPReferrer(referrer, blink::WebReferrerPolicyDefault);
66 } else { 66 } else {
67 request_.setHTTPHeaderField(blink::WebString::fromUTF8(header), 67 request_.setHTTPHeaderField(blink::WebString::fromUTF8(header),
68 blink::WebString::fromUTF8(value)); 68 blink::WebString::fromUTF8(value));
69 } 69 }
70 } 70 }
71 71
72 void ResourceFetcherImpl::SetSkipServiceWorker(bool skip_service_worker) { 72 void ResourceFetcherImpl::SetSkipServiceWorker(
73 blink::WebURLRequest::SkipServiceWorker skip_service_worker) {
73 DCHECK(!request_.isNull()); 74 DCHECK(!request_.isNull());
74 DCHECK(!loader_); 75 DCHECK(!loader_);
75 76
76 request_.setSkipServiceWorker(skip_service_worker); 77 request_.setSkipServiceWorker(skip_service_worker);
77 } 78 }
78 79
79 void ResourceFetcherImpl::SetCachePolicy(blink::WebCachePolicy policy) { 80 void ResourceFetcherImpl::SetCachePolicy(blink::WebCachePolicy policy) {
80 DCHECK(!request_.isNull()); 81 DCHECK(!request_.isNull());
81 DCHECK(!loader_); 82 DCHECK(!loader_);
82 83
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 callback.Run(status() == LOAD_FAILED ? blink::WebURLResponse() : response(), 144 callback.Run(status() == LOAD_FAILED ? blink::WebURLResponse() : response(),
144 status() == LOAD_FAILED ? std::string() : data()); 145 status() == LOAD_FAILED ? std::string() : data());
145 } 146 }
146 147
147 void ResourceFetcherImpl::Cancel() { 148 void ResourceFetcherImpl::Cancel() {
148 loader_->cancel(); 149 loader_->cancel();
149 WebURLLoaderClientImpl::Cancel(); 150 WebURLLoaderClientImpl::Cancel();
150 } 151 }
151 152
152 } // namespace content 153 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698