content/renderer/fetchers/resource_fetcher_impl.h - Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/fetchers/resource_fetcher_impl.h

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments explaing why skip is set to ::Controlling for fallback requests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/service_worker/service_worker_types.h ('K') | « content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc ('k') | content/renderer/fetchers/resource_fetcher_impl.cc » ('j') | third_party/WebKit/Source/platform/network/ResourceRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/fetchers/resource_fetcher_impl.h

diff --git a/content/renderer/fetchers/resource_fetcher_impl.h b/content/renderer/fetchers/resource_fetcher_impl.h

index 38f3bb39940f8f9eb83e87278e3fef02c39b4a44..731ca48832c4ece37fae93af5a10e0a49ce7208d 100644

--- a/content/renderer/fetchers/resource_fetcher_impl.h

+++ b/content/renderer/fetchers/resource_fetcher_impl.h

@@ -35,7 +35,8 @@ class ResourceFetcherImpl : public ResourceFetcher,

void SetMethod(const std::string& method) override;

void SetBody(const std::string& body) override;

void SetHeader(const std::string& header, const std::string& value) override;

- void SetSkipServiceWorker(bool skip_service_worker) override;

+ void SetSkipServiceWorker(

+ blink::WebURLRequest::SkipServiceWorker skip_service_worker) override;

void SetCachePolicy(blink::WebCachePolicy policy) override;

void SetLoaderOptions(const blink::WebURLLoaderOptions& options) override;

void Start(blink::WebFrame* frame,