content/renderer/pepper/pepper_url_loader_host.cc - Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_url_loader_host.cc

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments explaing why skip is set to ::Controlling for fallback requests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/service_worker/service_worker_types.h ('K') | « content/renderer/fetchers/resource_fetcher_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | third_party/WebKit/Source/platform/network/ResourceRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_url_loader_host.cc

diff --git a/content/renderer/pepper/pepper_url_loader_host.cc b/content/renderer/pepper/pepper_url_loader_host.cc

index ac34ce9ca66cd5be4b3ac8cbeb0fd476cd45ee78..d8b75dda4aa68762341de1ce370829aa2eb76e88 100644

--- a/content/renderer/pepper/pepper_url_loader_host.cc

+++ b/content/renderer/pepper/pepper_url_loader_host.cc

@@ -264,7 +264,9 @@ int32_t PepperURLLoaderHost::InternalOnHostMsgOpen(

// The requests from the plugins with private permission which can bypass same

// origin must skip the ServiceWorker.

web_request.setSkipServiceWorker(

- host()->permissions().HasPermission(ppapi::PERMISSION_PRIVATE));

+ host()->permissions().HasPermission(ppapi::PERMISSION_PRIVATE)

+ ? blink::WebURLRequest::SkipServiceWorker::All

+ : blink::WebURLRequest::SkipServiceWorker::None);

WebURLLoaderOptions options;

if (has_universal_access_) {