Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2105183002: Remove parameter from Privacy prefs initializer (Closed)

Created:
4 years, 5 months ago by cco3
Modified:
4 years, 5 months ago
Reviewers:
Peter Wen, gone
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org, gayane+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove parameter from Privacy prefs initializer The context parameter for the PrivacyPreferencesManager initializer is superfluous given that we just use it to get the app context. The new ContextUtils.getApplicationContext() does this this through a static method. This change removes the context parameter and updates all client code. BUG=624184 Committed: https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63 Cr-Commit-Position: refs/heads/master@{#402850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -41 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/CrashDumpUploadPreference.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
cco3
Hi wnwen@, would you be able to review this change using ContextUtils?
4 years, 5 months ago (2016-06-28 23:39:06 UTC) #2
Peter Wen
lgtm Thanks for the clean-up! A lot clearer in terms of what getInstance actually needs, ...
4 years, 5 months ago (2016-06-29 12:28:12 UTC) #3
cco3
Hi Dan, would you be available to give owners approval for this code cleanup change?
4 years, 5 months ago (2016-06-29 16:25:09 UTC) #5
gone
Was going to defer to Peter for the review, but I'm glad to see that ...
4 years, 5 months ago (2016-06-29 16:26:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105183002/1
4 years, 5 months ago (2016-06-29 16:40:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 17:28:15 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 17:28:17 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 17:29:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/814dd6ada11ce9b79feb7994a75d67c49d18ab63
Cr-Commit-Position: refs/heads/master@{#402850}

Powered by Google App Engine
This is Rietveld 408576698