chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java - Issue 2105183002: Remove parameter from Privacy prefs initializer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java

Issue 2105183002: Remove parameter from Privacy prefs initializer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/CrashDumpUploadPreference.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java

index 6b84a518c067403dbc43932f5bb718117a9b0c4e..a8244ae945160cb62024737772fb17974b68ca89 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java

@@ -46,9 +46,7 @@ public class PhysicalWebOptInActivity extends AppCompatActivity {

@Override

public void onClick(View v) {

PhysicalWebUma.onOptInDeclineButtonPressed(PhysicalWebOptInActivity.this);

- PrivacyPreferencesManager privacyPrefManager =

- PrivacyPreferencesManager.getInstance(PhysicalWebOptInActivity.this);

- privacyPrefManager.setPhysicalWebEnabled(false);

+ PrivacyPreferencesManager.getInstance().setPhysicalWebEnabled(false);

finish();

}

});

@@ -58,9 +56,7 @@ public class PhysicalWebOptInActivity extends AppCompatActivity {

@Override

public void onClick(View v) {

PhysicalWebUma.onOptInEnableButtonPressed(PhysicalWebOptInActivity.this);

- PrivacyPreferencesManager privacyPrefManager =

- PrivacyPreferencesManager.getInstance(PhysicalWebOptInActivity.this);

- privacyPrefManager.setPhysicalWebEnabled(true);

+ PrivacyPreferencesManager.getInstance().setPhysicalWebEnabled(true);

startActivity(createListUrlsIntent(PhysicalWebOptInActivity.this));

finish();

}