chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java - Issue 2105183002: Remove parameter from Privacy prefs initializer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java

Issue 2105183002: Remove parameter from Privacy prefs initializer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/CrashDumpUploadPreference.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java

index fa8c834f43e7d496cb165c359b6f112c4b87605a..689524c1d42b5eb1a88d471f77ebf4d6ea1853b6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java

@@ -80,9 +80,8 @@ public class PhysicalWebPreferenceFragment extends PreferenceFragment {

ChromeSwitchPreference physicalWebSwitch =

(ChromeSwitchPreference) findPreference(PREF_PHYSICAL_WEB_SWITCH);

- boolean isPhysicalWebEnabled =

- PrivacyPreferencesManager.getInstance(getActivity()).isPhysicalWebEnabled();

- physicalWebSwitch.setChecked(isPhysicalWebEnabled);

+ physicalWebSwitch.setChecked(

+ PrivacyPreferencesManager.getInstance().isPhysicalWebEnabled());

physicalWebSwitch.setOnPreferenceChangeListener(new OnPreferenceChangeListener() {

@Override

@@ -94,7 +93,7 @@ public class PhysicalWebPreferenceFragment extends PreferenceFragment {

} else {

PhysicalWebUma.onPrefsFeatureDisabled(getActivity());

}

- PrivacyPreferencesManager.getInstance(getActivity()).setPhysicalWebEnabled(enabled);

+ PrivacyPreferencesManager.getInstance().setPhysicalWebEnabled(enabled);

return true;

}

});