chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java - Issue 2105183002: Remove parameter from Privacy prefs initializer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

Issue 2105183002: Remove parameter from Privacy prefs initializer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

index ee65ce4acac83218dd87779de7b3f9facd0e6c25..8f8291b379e172e31a1930774bbdb469b610969f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

@@ -50,8 +50,7 @@ public class PrivacyPreferences extends PreferenceFragment

@Override

public void onCreate(Bundle savedInstanceState) {

super.onCreate(savedInstanceState);

- PrivacyPreferencesManager privacyPrefManager =

- PrivacyPreferencesManager.getInstance(getActivity());

+ PrivacyPreferencesManager privacyPrefManager = PrivacyPreferencesManager.getInstance();

privacyPrefManager.migrateNetworkPredictionPreferences();

addPreferencesFromResource(R.xml.privacy_preferences);

getActivity().setTitle(R.string.prefs_privacy);

@@ -148,8 +147,7 @@ public class PrivacyPreferences extends PreferenceFragment

} else if (PREF_CRASH_DUMP_UPLOAD_NO_CELLULAR.equals(key)) {

PrefServiceBridge.getInstance().setCrashReportingEnabled((boolean) newValue);

} else if (PREF_CRASH_DUMP_UPLOAD.equals(key)) {

- PrivacyPreferencesManager.getInstance(getActivity()).setUploadCrashDump(

- (String) newValue);

+ PrivacyPreferencesManager.getInstance().setUploadCrashDump((String) newValue);

}

return true;

@@ -167,8 +165,7 @@ public class PrivacyPreferences extends PreferenceFragment

public void updateSummaries() {

PrefServiceBridge prefServiceBridge = PrefServiceBridge.getInstance();

- PrivacyPreferencesManager privacyPrefManager =

- PrivacyPreferencesManager.getInstance(getActivity());

+ PrivacyPreferencesManager privacyPrefManager = PrivacyPreferencesManager.getInstance();

CharSequence textOn = getActivity().getResources().getText(R.string.text_on);

CharSequence textOff = getActivity().getResources().getText(R.string.text_off);