Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2104383003: Hide GrDrawVerticesBatch::Geometry and rename to Mesh (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@moremore
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Hide GrDrawVerticesBatch::Geometry and rename to Mesh GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104383003 Committed: https://skia.googlesource.com/skia/+/d92b4198aef1ba719222e737edf6e28a39b43b6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -67 lines) Patch
M src/gpu/GrDrawContext.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.h View 4 chunks +14 lines, -25 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.cpp View 8 chunks +33 lines, -36 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
bsalomon
4 years, 5 months ago (2016-06-30 14:12:52 UTC) #3
robertphillips
lgtm
4 years, 5 months ago (2016-06-30 14:19:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104383003/1
4 years, 5 months ago (2016-06-30 14:20:12 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 14:46:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104383003/1
4 years, 5 months ago (2016-06-30 14:58:28 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 14:59:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d92b4198aef1ba719222e737edf6e28a39b43b6d

Powered by Google App Engine
This is Rietveld 408576698