Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2110853004: Even more hiding of Geometry structs in GrBatch subclasses. (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@moregeom
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Even more hiding of Geometry structs in GrBatch subclasses. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110853004 Committed: https://skia.googlesource.com/skia/+/0432dd6ee62d0c1c1ca67b7f6f6fcf3de75aaf77

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 4

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -115 lines) Patch
M src/gpu/GrDrawContext.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 1 2 6 chunks +44 lines, -44 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 6 chunks +26 lines, -43 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.h View 1 3 chunks +8 lines, -15 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download

Dependent Patchsets:

Issue 2104383003 Patch 1

Messages

Total messages: 14 (7 generated)
bsalomon
4 years, 5 months ago (2016-06-29 21:38:32 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110853004/20001
4 years, 5 months ago (2016-06-29 21:38:48 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/2110853004/diff/20001/src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp File src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp (right): https://codereview.chromium.org/2110853004/diff/20001/src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp#newcode137 src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp:137: w /= 2; miter limit -> half stroke ...
4 years, 5 months ago (2016-06-29 21:53:48 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 22:03:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110853004/40001
4 years, 5 months ago (2016-06-30 14:00:09 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/0432dd6ee62d0c1c1ca67b7f6f6fcf3de75aaf77
4 years, 5 months ago (2016-06-30 14:19:30 UTC) #13
bsalomon
4 years, 5 months ago (2016-06-30 19:12:07 UTC) #14
Message was sent while issue was closed. 
https://codereview.chromium.org/2110853004/diff/20001/src/gpu/batches/GrAALin...
File src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp (right):

https://codereview.chromium.org/2110853004/diff/20001/src/gpu/batches/GrAALin...
src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp:137: w /= 2;
On 2016/06/29 21:53:48, robertphillips wrote:
> miter limit -> half stroke width ?

Done.

https://codereview.chromium.org/2110853004/diff/20001/src/gpu/batches/GrAALin...
src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp:143: }
On 2016/06/29 21:53:48, robertphillips wrote:
> this indent seems a bit wonky

Done.

Powered by Google App Engine
This is Rietveld 408576698