Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2116533002: Hide MSAAPathBatch::Geometry and rename to PathInfo (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@moredrawvertices
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Hide MSAAPathBatch::Geometry and rename to PathInfo GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2116533002 Committed: https://skia.googlesource.com/skia/+/50c56a39db30a4eb6b80e75db90ce9c1efe36b4f

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use kTolerance instead of a param #

Patch Set 3 : fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -47 lines) Patch
M src/gpu/batches/GrMSAAPathRenderer.cpp View 1 2 10 chunks +31 lines, -47 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
bsalomon
4 years, 5 months ago (2016-06-30 14:34:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116533002/1
4 years, 5 months ago (2016-06-30 15:03:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 15:28:14 UTC) #7
robertphillips
https://codereview.chromium.org/2116533002/diff/1/src/gpu/batches/GrMSAAPathRenderer.cpp File src/gpu/batches/GrMSAAPathRenderer.cpp (right): https://codereview.chromium.org/2116533002/diff/1/src/gpu/batches/GrMSAAPathRenderer.cpp#newcode227 src/gpu/batches/GrMSAAPathRenderer.cpp:227: The usage of 'tolerance', 'kTolerance' & 'fTolerance' seems a ...
4 years, 5 months ago (2016-06-30 17:10:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116533002/40001
4 years, 5 months ago (2016-06-30 17:29:59 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 5 months ago (2016-06-30 17:30:01 UTC) #11
robertphillips
lgtm
4 years, 5 months ago (2016-06-30 19:04:34 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:05:35 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/50c56a39db30a4eb6b80e75db90ce9c1efe36b4f

Powered by Google App Engine
This is Rietveld 408576698