Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2102833002: cc: Fixup cc to not use auto to deduce a raw pointer. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj, dcheng, ericrk
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri, posciak+watch_chromium.org, wfh+watch_chromium.org, feature-media-reviews_chromium.org, eroman, asvitkine+watch_chromium.org, tracing+reviews_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, scheduler-bugs_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fixup cc to not use auto to deduce a raw pointer. This patch updates cc to not use auto to deduce a raw pointer. R=danakj, dcheng BUG=554600 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a2e89438d7c31e24f0648edef90d712a689e8053 Cr-Commit-Position: refs/heads/master@{#406457}

Patch Set 1 #

Patch Set 2 : cc #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M cc/ipc/cc_param_traits.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/layer_proto_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/video_layer_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/output/delegating_renderer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/output/output_surface.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/render_pass.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/scheduler/begin_frame_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/test/layer_test_common.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tiles/picture_layer_tiling_set_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/tiles/raster_tile_priority_queue_required.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/tile_manager_perftest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_serialization.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (6 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-27 21:48:22 UTC) #3
ericrk
lgtm
4 years, 5 months ago (2016-06-27 21:53:23 UTC) #5
danakj
LGTM
4 years, 5 months ago (2016-06-27 22:14:25 UTC) #6
vmpstr
dcheng, could you take a look with your security reviewer hat on?
4 years, 5 months ago (2016-06-28 20:43:17 UTC) #7
vmpstr
Rebased this, dcheng@ could you take a look at cc/ipc/cc_param_traits.cc?
4 years, 5 months ago (2016-07-18 20:23:52 UTC) #8
vmpstr
dcheng, ping :)
4 years, 5 months ago (2016-07-19 21:15:52 UTC) #9
dcheng
rs lgtm for ipc changes (sorry didn't realize i actually owned something in this one!)
4 years, 5 months ago (2016-07-20 00:41:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102833002/40001
4 years, 5 months ago (2016-07-20 00:43:57 UTC) #13
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-20 00:43:59 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 02:05:49 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 02:05:55 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 02:07:39 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a2e89438d7c31e24f0648edef90d712a689e8053
Cr-Commit-Position: refs/heads/master@{#406457}

Powered by Google App Engine
This is Rietveld 408576698