Fix BundleData::GetBundleRootDirOutput() for non-default toolchain.

Fix BundleData::GetBundleRootDirOutput() for non-default toolchain.

The "create_bundle" targets defines in build/config/{mac,ios}/rules.gni
put their outputs in "$root_out_dir". This directory is different from
the top-level output directory from BuildSettings and instead correspond
to the Settings toolchain output directory.

Fix BundleData::GetBundleRootDirOutput() to compute the bundle root
directory output relative to the toolchain output directory to fix
dependencies when a "create_bundle" target is defined in the non-default
toolchain.

Fix TestWithScope constructor to ensure that BuildSettings::SetBuildDir
call is made before the call to Settings constructor (as the toolchain
output directory is initialized from the BuildSettings build_dir).

Remove unnecessary calls to setup.build_settings().SetBuildDir() as
the value is already set in TestWithScope constructor.

BUG=603180
Committed: https://crrev.com/3fed8056522b525d1ee49acc5a04c6b3c3c229bb
Cr-Commit-Position: refs/heads/master@{#403446}

[sdefresne, 2016-06-29 10:33:50]

sdefresne@chromium.org changed reviewers:
+ rsesek@chromium.org

[sdefresne, 2016-06-29 10:33:51]

Please take a first look before I send this to Brett.

This is a prerequisite to using a different toolchain for building fat binaries
for Chrome on iOS.

[Robert Sesek, 2016-06-29 17:23:04]

LGTM

[sdefresne, 2016-06-29 17:24:41]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2016-06-29 17:24:42]

brettw: for OWNERS review

[brettw, 2016-06-29 23:04:36]

lgtm

[sdefresne, 2016-07-01 12:57:55]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-07-01 12:57:55]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2101923006/#ps10001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-01 12:58:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 13:30:06]

Committed patchset #2 (id:10001)

[commit-bot: I haz the power, 2016-07-01 13:31:29]

Description was changed from

==========
Fix BundleData::GetBundleRootDirOutput() for non-default toolchain.

The "create_bundle" targets defines in build/config/{mac,ios}/rules.gni
put their outputs in "$root_out_dir". This directory is different from
the top-level output directory from BuildSettings and instead correspond
to the Settings toolchain output directory.

Fix BundleData::GetBundleRootDirOutput() to compute the bundle root
directory output relative to the toolchain output directory to fix
dependencies when a "create_bundle" target is defined in the non-default
toolchain.

Fix TestWithScope constructor to ensure that BuildSettings::SetBuildDir
call is made before the call to Settings constructor (as the toolchain
output directory is initialized from the BuildSettings build_dir).

Remove unnecessary calls to setup.build_settings().SetBuildDir() as
the value is already set in TestWithScope constructor.

BUG=603180
==========

to

==========
Fix BundleData::GetBundleRootDirOutput() for non-default toolchain.

The "create_bundle" targets defines in build/config/{mac,ios}/rules.gni
put their outputs in "$root_out_dir". This directory is different from
the top-level output directory from BuildSettings and instead correspond
to the Settings toolchain output directory.

Fix BundleData::GetBundleRootDirOutput() to compute the bundle root
directory output relative to the toolchain output directory to fix
dependencies when a "create_bundle" target is defined in the non-default
toolchain.

Fix TestWithScope constructor to ensure that BuildSettings::SetBuildDir
call is made before the call to Settings constructor (as the toolchain
output directory is initialized from the BuildSettings build_dir).

Remove unnecessary calls to setup.build_settings().SetBuildDir() as
the value is already set in TestWithScope constructor.

BUG=603180

Committed: https://crrev.com/3fed8056522b525d1ee49acc5a04c6b3c3c229bb
Cr-Commit-Position: refs/heads/master@{#403446}
==========

[commit-bot: I haz the power, 2016-07-01 13:31:30]

Patchset 2 (id:??) landed as
https://crrev.com/3fed8056522b525d1ee49acc5a04c6b3c3c229bb
Cr-Commit-Position: refs/heads/master@{#403446}