Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: tools/gn/ninja_action_target_writer_unittest.cc

Issue 2101923006: Fix BundleData::GetBundleRootDirOutput() for non-default toolchain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@create-bundle-deps
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_rebase_path_unittest.cc ('k') | tools/gn/ninja_binary_target_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_action_target_writer_unittest.cc
diff --git a/tools/gn/ninja_action_target_writer_unittest.cc b/tools/gn/ninja_action_target_writer_unittest.cc
index 21a7ea558c1461be474bcae0b9e88fa42557af2e..ab871d106783eebb7aeb9c8278e57410d3183a6a 100644
--- a/tools/gn/ninja_action_target_writer_unittest.cc
+++ b/tools/gn/ninja_action_target_writer_unittest.cc
@@ -13,10 +13,8 @@
#include "tools/gn/test_with_scope.h"
TEST(NinjaActionTargetWriter, WriteOutputFilesForBuildLine) {
- TestWithScope setup;
Err err;
-
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
+ TestWithScope setup;
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
target.set_output_type(Target::ACTION_FOREACH);
@@ -39,10 +37,9 @@ TEST(NinjaActionTargetWriter, WriteOutputFilesForBuildLine) {
// Tests an action with no sources.
TEST(NinjaActionTargetWriter, ActionNoSources) {
- TestWithScope setup;
Err err;
+ TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
target.set_output_type(Target::ACTION);
@@ -79,10 +76,9 @@ TEST(NinjaActionTargetWriter, ActionNoSources) {
// Tests an action with no sources and console = true
TEST(NinjaActionTargetWriter, ActionNoSourcesConsole) {
- TestWithScope setup;
Err err;
+ TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
target.set_output_type(Target::ACTION);
@@ -121,10 +117,9 @@ TEST(NinjaActionTargetWriter, ActionNoSourcesConsole) {
// Makes sure that we write sources as input dependencies for actions with
// both sources and inputs (ACTION_FOREACH treats the sources differently).
TEST(NinjaActionTargetWriter, ActionWithSources) {
- TestWithScope setup;
Err err;
+ TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
target.set_output_type(Target::ACTION);
@@ -161,10 +156,8 @@ TEST(NinjaActionTargetWriter, ActionWithSources) {
}
TEST(NinjaActionTargetWriter, ForEach) {
- TestWithScope setup;
Err err;
-
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
+ TestWithScope setup;
// Some dependencies that the action can depend on. Use actions for these
// so they have a nice platform-independent stamp file that can appear in the
@@ -243,10 +236,9 @@ TEST(NinjaActionTargetWriter, ForEach) {
}
TEST(NinjaActionTargetWriter, ForEachWithDepfile) {
- TestWithScope setup;
Err err;
+ TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
target.set_output_type(Target::ACTION_FOREACH);
@@ -306,10 +298,9 @@ TEST(NinjaActionTargetWriter, ForEachWithDepfile) {
}
TEST(NinjaActionTargetWriter, ForEachWithResponseFile) {
- TestWithScope setup;
Err err;
+ TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
target.set_output_type(Target::ACTION_FOREACH);
« no previous file with comments | « tools/gn/function_rebase_path_unittest.cc ('k') | tools/gn/ninja_binary_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698