Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: tools/gn/function_rebase_path_unittest.cc

Issue 2101923006: Fix BundleData::GetBundleRootDirOutput() for non-default toolchain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@create-bundle-deps
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/bundle_data.cc ('k') | tools/gn/ninja_action_target_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_rebase_path_unittest.cc
diff --git a/tools/gn/function_rebase_path_unittest.cc b/tools/gn/function_rebase_path_unittest.cc
index 456d4fb8a967798a8a57c121bf6736e3d5c63598..4b09790fa7ebe18910872058ea9a555d0bde707c 100644
--- a/tools/gn/function_rebase_path_unittest.cc
+++ b/tools/gn/function_rebase_path_unittest.cc
@@ -32,7 +32,6 @@ std::string RebaseOne(Scope* scope,
TEST(RebasePath, Strings) {
TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Scope* scope = setup.scope();
scope->set_source_dir(SourceDir("//tools/gn/"));
@@ -151,7 +150,6 @@ TEST(RebasePath, StringsSystemPaths) {
// Test list input.
TEST(RebasePath, List) {
TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
setup.scope()->set_source_dir(SourceDir("//tools/gn/"));
std::vector<Value> args;
@@ -175,7 +173,6 @@ TEST(RebasePath, List) {
TEST(RebasePath, Errors) {
TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
// No arg input should issue an error.
Err err;
« no previous file with comments | « tools/gn/bundle_data.cc ('k') | tools/gn/ninja_action_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698