Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tools/gn/ninja_create_bundle_target_writer_unittest.cc

Issue 2101923006: Fix BundleData::GetBundleRootDirOutput() for non-default toolchain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@create-bundle-deps
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_copy_target_writer_unittest.cc ('k') | tools/gn/ninja_group_target_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_create_bundle_target_writer_unittest.cc
diff --git a/tools/gn/ninja_create_bundle_target_writer_unittest.cc b/tools/gn/ninja_create_bundle_target_writer_unittest.cc
index 876aeda6b8c35fe29127113edc570dbb2f4a99c3..dee99c481ea3aea5a7ec86671ba6b13d66b650e2 100644
--- a/tools/gn/ninja_create_bundle_target_writer_unittest.cc
+++ b/tools/gn/ninja_create_bundle_target_writer_unittest.cc
@@ -26,9 +26,7 @@ void SetupBundleDataDir(BundleData* bundle_data, const std::string& root_dir) {
// Tests multiple files with an output pattern.
TEST(NinjaCreateBundleTargetWriter, Run) {
Err err;
-
TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target bundle_data(setup.settings(), Label(SourceDir("//foo/"), "data"));
bundle_data.set_output_type(Target::BUNDLE_DATA);
@@ -70,9 +68,7 @@ TEST(NinjaCreateBundleTargetWriter, Run) {
// Tests multiple files from asset catalog.
TEST(NinjaCreateBundleTargetWriter, AssetCatalog) {
Err err;
-
TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target bundle_data(setup.settings(), Label(SourceDir("//foo/"), "data"));
bundle_data.set_output_type(Target::BUNDLE_DATA);
@@ -120,9 +116,7 @@ TEST(NinjaCreateBundleTargetWriter, AssetCatalog) {
// correctly.
TEST(NinjaCreateBundleTargetWriter, PhonyTarget) {
Err err;
-
TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target create_bundle(
setup.settings(),
@@ -148,9 +142,7 @@ TEST(NinjaCreateBundleTargetWriter, PhonyTarget) {
// some asset catalog.
TEST(NinjaCreateBundleTargetWriter, Complex) {
Err err;
-
TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target bundle_data0(setup.settings(),
Label(SourceDir("//qux/"), "info_plist"));
@@ -251,9 +243,7 @@ TEST(NinjaCreateBundleTargetWriter, Complex) {
// Tests code signing steps.
TEST(NinjaCreateBundleTargetWriter, CodeSigning) {
Err err;
-
TestWithScope setup;
- setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target executable(setup.settings(), Label(SourceDir("//baz/"), "quz"));
executable.set_output_type(Target::EXECUTABLE);
« no previous file with comments | « tools/gn/ninja_copy_target_writer_unittest.cc ('k') | tools/gn/ninja_group_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698