Adjust sizes of material design shadows based on Sebastien's feedback.

Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons
as they're hovered. This better matches Sebastien's original intent
(and he has approved the resulting screenshots).

Several changes occur simultaneously:
 1. The blur radius and offset are changed from 2dp to 1dp.
 2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175.
    This bug was somewhat papered over by the (correct) clipping margins that
    gfx::ShadowValue::GetMargin calculated, but it still manifested as a
    shadow that cut off too abruptly. I sussed this out after Sebastien
    spotted the visual defect.
 3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
    tweaked. The half pixel offset doesn't seem necessary any more with the
    above fixes.

BUG=571500, 624175
Committed: https://crrev.com/bf0e5b5fd9b152e45eb4bd48e061c0d2fdfaffe6
Cr-Commit-Position: refs/heads/master@{#402968}

[Evan Stade, 2016-06-28 23:13:20]

Description was changed from

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

BUG=571500
==========

to

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons as they're
hovered. Several changes occur simultaneously:
1. The blur radius and offset are changed from 2dp to 1dp. This better matches
Sebastien's original intent (and he has approved the resulting screenshot).
2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175. This
bug was somewhat papered over by the (correct) clipping margins that
gfx::ShadowValue::GetMaring calculated, but it still manifested as a shadow that
cut off too abruptly. I sussed this out after Sebastien spotted the visual
defect.
3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
tweaked. The half pixel offset doesn't seem necessary any more with the above
fixes.

BUG=571500,624175
==========

[Evan Stade, 2016-06-28 23:13:20]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-06-28 23:18:57]

Description was changed from

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons as they're
hovered. Several changes occur simultaneously:
1. The blur radius and offset are changed from 2dp to 1dp. This better matches
Sebastien's original intent (and he has approved the resulting screenshot).
2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175. This
bug was somewhat papered over by the (correct) clipping margins that
gfx::ShadowValue::GetMaring calculated, but it still manifested as a shadow that
cut off too abruptly. I sussed this out after Sebastien spotted the visual
defect.
3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
tweaked. The half pixel offset doesn't seem necessary any more with the above
fixes.

BUG=571500,624175
==========

to

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons as they're
hovered. This better matches Sebastien's original intent (and he has approved
the resulting screenshots).

Several changes occur simultaneously:
1. The blur radius and offset are changed from 2dp to 1dp. 
2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175. This
bug was somewhat papered over by the (correct) clipping margins that
gfx::ShadowValue::GetMaring calculated, but it still manifested as a shadow that
cut off too abruptly. I sussed this out after Sebastien spotted the visual
defect.
3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
tweaked. The half pixel offset doesn't seem necessary any more with the above
fixes.

BUG=571500,624175
==========

[Evan Stade, 2016-06-28 23:20:29]

Description was changed from

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons as they're
hovered. This better matches Sebastien's original intent (and he has approved
the resulting screenshots).

Several changes occur simultaneously:
1. The blur radius and offset are changed from 2dp to 1dp. 
2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175. This
bug was somewhat papered over by the (correct) clipping margins that
gfx::ShadowValue::GetMaring calculated, but it still manifested as a shadow that
cut off too abruptly. I sussed this out after Sebastien spotted the visual
defect.
3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
tweaked. The half pixel offset doesn't seem necessary any more with the above
fixes.

BUG=571500,624175
==========

to

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons as they're
hovered. This better matches Sebastien's original intent (and he has approved
the resulting screenshots).

Several changes occur simultaneously:
1. The blur radius and offset are changed from 2dp to 1dp. 
2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175. This
bug was somewhat papered over by the (correct) clipping margins that
gfx::ShadowValue::GetMargin calculated, but it still manifested as a shadow that
cut off too abruptly. I sussed this out after Sebastien spotted the visual
defect.
3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
tweaked. The half pixel offset doesn't seem necessary any more with the above
fixes.

BUG=571500,624175
==========

[Evan Stade, 2016-06-28 23:21:27]

Description was changed from

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons as they're
hovered. This better matches Sebastien's original intent (and he has approved
the resulting screenshots).

Several changes occur simultaneously:
1. The blur radius and offset are changed from 2dp to 1dp. 
2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175. This
bug was somewhat papered over by the (correct) clipping margins that
gfx::ShadowValue::GetMargin calculated, but it still manifested as a shadow that
cut off too abruptly. I sussed this out after Sebastien spotted the visual
defect.
3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
tweaked. The half pixel offset doesn't seem necessary any more with the above
fixes.

BUG=571500,624175
==========

to

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons
as they're hovered. This better matches Sebastien's original intent
(and he has approved the resulting screenshots).

Several changes occur simultaneously:
 1. The blur radius and offset are changed from 2dp to 1dp. 
 2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175.
    This bug was somewhat papered over by the (correct) clipping margins that
    gfx::ShadowValue::GetMargin calculated, but it still manifested as a
    shadow that cut off too abruptly. I sussed this out after Sebastien
    spotted the visual defect.
 3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
    tweaked. The half pixel offset doesn't seem necessary any more with the
    above fixes.

BUG=571500,624175
==========

[sky, 2016-06-29 03:18:05]

LGTM

[Evan Stade, 2016-06-29 20:48:00]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-06-29 20:49:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 22:40:33]

Description was changed from

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons
as they're hovered. This better matches Sebastien's original intent
(and he has approved the resulting screenshots).

Several changes occur simultaneously:
 1. The blur radius and offset are changed from 2dp to 1dp. 
 2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175.
    This bug was somewhat papered over by the (correct) clipping margins that
    gfx::ShadowValue::GetMargin calculated, but it still manifested as a
    shadow that cut off too abruptly. I sussed this out after Sebastien
    spotted the visual defect.
 3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
    tweaked. The half pixel offset doesn't seem necessary any more with the
    above fixes.

BUG=571500,624175
==========

to

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons
as they're hovered. This better matches Sebastien's original intent
(and he has approved the resulting screenshots).

Several changes occur simultaneously:
 1. The blur radius and offset are changed from 2dp to 1dp. 
 2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175.
    This bug was somewhat papered over by the (correct) clipping margins that
    gfx::ShadowValue::GetMargin calculated, but it still manifested as a
    shadow that cut off too abruptly. I sussed this out after Sebastien
    spotted the visual defect.
 3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
    tweaked. The half pixel offset doesn't seem necessary any more with the
    above fixes.

BUG=571500,624175
==========

[commit-bot: I haz the power, 2016-06-29 22:40:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 22:42:08]

Description was changed from

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons
as they're hovered. This better matches Sebastien's original intent
(and he has approved the resulting screenshots).

Several changes occur simultaneously:
 1. The blur radius and offset are changed from 2dp to 1dp. 
 2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175.
    This bug was somewhat papered over by the (correct) clipping margins that
    gfx::ShadowValue::GetMargin calculated, but it still manifested as a
    shadow that cut off too abruptly. I sussed this out after Sebastien
    spotted the visual defect.
 3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
    tweaked. The half pixel offset doesn't seem necessary any more with the
    above fixes.

BUG=571500,624175
==========

to

==========
Adjust sizes of material design shadows based on Sebastien's feedback.

This CL changes the size of the shadows on the call to action buttons
as they're hovered. This better matches Sebastien's original intent
(and he has approved the resulting screenshots).

Several changes occur simultaneously:
 1. The blur radius and offset are changed from 2dp to 1dp.
 2. A bug in gfx::CreateShadowDrawLooper is corrected. See crbug.com/624175.
    This bug was somewhat papered over by the (correct) clipping margins that
    gfx::ShadowValue::GetMargin calculated, but it still manifested as a
    shadow that cut off too abruptly. I sussed this out after Sebastien
    spotted the visual defect.
 3. The way the shadow is painted in BorderShadowLayerDelegate is slightly
    tweaked. The half pixel offset doesn't seem necessary any more with the
    above fixes.

BUG=571500,624175

Committed: https://crrev.com/bf0e5b5fd9b152e45eb4bd48e061c0d2fdfaffe6
Cr-Commit-Position: refs/heads/master@{#402968}
==========

[commit-bot: I haz the power, 2016-06-29 22:42:09]

Patchset 3 (id:??) landed as
https://crrev.com/bf0e5b5fd9b152e45eb4bd48e061c0d2fdfaffe6
Cr-Commit-Position: refs/heads/master@{#402968}