Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: ui/views/controls/button/md_text_button.cc

Issue 2101863002: Adjust sizes of material design shadows based on Sebastien's feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug link Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/animation/ink_drop_painted_layer_delegates.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/md_text_button.cc
diff --git a/ui/views/controls/button/md_text_button.cc b/ui/views/controls/button/md_text_button.cc
index ec863e03dcd87c4d4f6cb45f36cb10c065543ca9..c82ef7b4bc9e34ce09d546a54c3bd91199e5b0d5 100644
--- a/ui/views/controls/button/md_text_button.cc
+++ b/ui/views/controls/button/md_text_button.cc
@@ -180,11 +180,13 @@ std::unique_ptr<views::InkDropHighlight> MdTextButton::CreateInkDropHighlight()
return LabelButton::CreateInkDropHighlight();
// The call to action hover effect is a shadow.
- const int kYOffset = 2;
- const int kSkiaBlurRadius = 2;
+ const int kYOffset = 1;
+ const int kSkiaBlurRadius = 1;
std::vector<gfx::ShadowValue> shadows;
- // The notion of blur that gfx::ShadowValue uses is twice the skia value,
- // which is a number of pixels outside of the shadowed area.
+ // The notion of blur that gfx::ShadowValue uses is twice the Skia/CSS value.
+ // Skia counts the number of pixels outside the mask area whereas
+ // gfx::ShadowValue counts together the number of pixels inside and outside
+ // the mask bounds.
shadows.push_back(gfx::ShadowValue(gfx::Vector2d(0, kYOffset),
2 * kSkiaBlurRadius,
SkColorSetA(SK_ColorBLACK, 0x3D)));
« no previous file with comments | « ui/views/animation/ink_drop_painted_layer_delegates.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698