Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2100323002:
Reduce size of LinearBitmapPipeline (Closed)
DescriptionReduce size of LinearBitmapPipeline from 281K to 134K, but keep the same speed.
Speed checked using top25desk SKPS.
Size measured using:
llvm-nm-3.6 -print-file-name -print-size -U out/Release/libskia_core.a | awk '{totals[$1] += strtonum("0x" $3)} END { for (i in totals) {print totals[i], i}}' | sort -n | column -t
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100323002
Committed: https://skia.googlesource.com/skia/+/00dd4538a5c6331dfc3a52283e6ece40f0e9425d
Patch Set 1 #Patch Set 2 : Final chooser code. #Patch Set 3 : rename #Patch Set 4 : ssize_t #Patch Set 5 : remove ssize_t #Patch Set 6 : fix win32 alignment problems. #Patch Set 7 : Fix win32 alignment problems again. #Patch Set 8 : Fix namespace problems. #Patch Set 9 : Fix default ctor problem. #Patch Set 10 : Fix uninitialized variable. #
Total comments: 4
Patch Set 11 : Sync with new SK_VECTORCALL. #
Dependent Patchsets: Messages
Total messages: 55 (26 generated)
Description was changed from ========== Reduce the size of LBP by > 2. ========== to ========== Reduce the size of LBP by > 2. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100323002 ==========
rename
Description was changed from ========== Reduce the size of LBP by > 2. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100323002 ========== to ========== Reduce size of LinearBitmapPipeline from 281K to 134K, but keep the same speed. Speed checked using top25desk SKPS. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100323002 ==========
herb@google.com changed reviewers: + mtklein@google.com
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
ssize_t
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
Description was changed from ========== Reduce size of LinearBitmapPipeline from 281K to 134K, but keep the same speed. Speed checked using top25desk SKPS. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100323002 ========== to ========== Reduce size of LinearBitmapPipeline from 281K to 134K, but keep the same speed. Speed checked using top25desk SKPS. Size measured using: llvm-nm-3.6 -print-file-name -print-size -U out/Release/libskia_core.a | awk '{totals[$1] += strtonum("0x" $3)} END { for (i in totals) {print totals[i], i}}' | sort -n | column -t GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100323002 ==========
remove ssize_t
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
fix win32 alignment problems.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
Fix win32 alignment problems again.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
Fix namespace problems.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
Fix default ctor problem.
Fix uninitialized variable.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, with some small questions sorry about the rebase you'll need after SK_VECTORCALL https://codereview.chromium.org/2100323002/diff/180001/src/core/SkLinearBitma... File src/core/SkLinearBitmapPipeline.h (right): https://codereview.chromium.org/2100323002/diff/180001/src/core/SkLinearBitma... src/core/SkLinearBitmapPipeline.h:107: SkASSERTF(sizeof(Variant) <= sizeof(fSpace), Can't this be a static_assert? https://codereview.chromium.org/2100323002/diff/180001/src/core/SkLinearBitma... File src/core/SkLinearBitmapPipeline_core.h (right): https://codereview.chromium.org/2100323002/diff/180001/src/core/SkLinearBitma... src/core/SkLinearBitmapPipeline_core.h:11: #include <algorithm> ?
Sync with new SK_VECTORCALL.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2100323002/diff/180001/src/core/SkLinearBitma... File src/core/SkLinearBitmapPipeline.h (right): https://codereview.chromium.org/2100323002/diff/180001/src/core/SkLinearBitma... src/core/SkLinearBitmapPipeline.h:107: SkASSERTF(sizeof(Variant) <= sizeof(fSpace), On 2016/07/07 14:33:33, mtklein wrote: > Can't this be a static_assert? If I use static_assert, I can't report the sizes needed to fix the problem. https://codereview.chromium.org/2100323002/diff/180001/src/core/SkLinearBitma... File src/core/SkLinearBitmapPipeline_core.h (right): https://codereview.chromium.org/2100323002/diff/180001/src/core/SkLinearBitma... src/core/SkLinearBitmapPipeline_core.h:11: #include <algorithm> On 2016/07/07 14:33:33, mtklein wrote: > ? Needed to make some bots happy. Used for minmax.
The CQ bit was checked by herb@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/2100323002/#ps200001 (title: "Sync with new SK_VECTORCALL.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Reduce size of LinearBitmapPipeline from 281K to 134K, but keep the same speed.
Speed checked using top25desk SKPS.
Size measured using:
llvm-nm-3.6 -print-file-name -print-size -U out/Release/libskia_core.a | awk
'{totals[$1] += strtonum("0x" $3)} END { for (i in totals) {print totals[i],
i}}' | sort -n | column -t
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100323002
==========
to
==========
Reduce size of LinearBitmapPipeline from 281K to 134K, but keep the same speed.
Speed checked using top25desk SKPS.
Size measured using:
llvm-nm-3.6 -print-file-name -print-size -U out/Release/libskia_core.a | awk
'{totals[$1] += strtonum("0x" $3)} END { for (i in totals) {print totals[i],
i}}' | sort -n | column -t
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100323002
Committed:
https://skia.googlesource.com/skia/+/00dd4538a5c6331dfc3a52283e6ece40f0e9425d
==========
Message was sent while issue was closed.
Committed patchset #11 (id:200001) as https://skia.googlesource.com/skia/+/00dd4538a5c6331dfc3a52283e6ece40f0e9425d
Message was sent while issue was closed.
reed@google.com changed reviewers: + reed@google.com
Message was sent while issue was closed.
woot |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
