Remove ExecutionContextTask::taskNameForInstrumentation()

Remove ExecutionContextTask::taskNameForInstrumentation()

taskNameForInstrumentation() is a cause to define custom subclasses of
ExecutionContextTask and blocks removal of such custom subclasses.
This CL split it out to an argument of postTask() to enable further refactoring
of ExecutionContextTask subclasses.

BUG=478194
Committed: https://crrev.com/d25ee900e7efe3ad6c677868ff42fbbfd92b8fae
Cr-Commit-Position: refs/heads/master@{#402079}

[hiroshige, 2016-06-23 09:28:10]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 09:28:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2098433002/1

[hiroshige, 2016-06-23 09:46:48]

hiroshige@chromium.org changed reviewers:
+ kinuko@chromium.org, tzik@chromium.org

[hiroshige, 2016-06-23 09:46:49]

WDYT?

Alternatives are:
- Add ExecutionContextTask::m_taskNameForInstrumentation.
  cons: Adding String to possibly cross-thread ExecutionContextTask looks
unsafe.
- Provide |taskNameForInstrumentation| without adding a member, e.g. by adding
traits.
  cons: more complex implementation of ExecutionContextTask classes: see
https://codereview.chromium.org/1766903002/ for a draft CL.

[hiroshige, 2016-06-23 09:48:12]

Description was changed from

==========
Remove ExecutionContextTask::taskNameForInstrumentation()

taskNameForInstrumentation() is one of causes to define subclasses of
ExecutionContextTask.
This CL split it out to an argument of postTask() to enable further refactoring
of ExecutionContextTask subclasses.

BUG=478194
==========

to

==========
Remove ExecutionContextTask::taskNameForInstrumentation()

taskNameForInstrumentation() is a cause to define custom subclasses of
ExecutionContextTask and blocks removal of such custom subclasses.
This CL split it out to an argument of postTask() to enable further refactoring
of ExecutionContextTask subclasses.

BUG=478194
==========

[commit-bot: I haz the power, 2016-06-23 10:48:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 10:48:49]

Dry run: This issue passed the CQ dry run.

[kinuko, 2016-06-23 15:43:07]

I think this change makes sense. lgtm

[haraken, 2016-06-24 00:47:11]

LGTM

[tzik, 2016-06-24 03:56:41]

lgtm

[hiroshige, 2016-06-26 08:08:07]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-06-26 08:08:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-26 09:24:16]

Description was changed from

==========
Remove ExecutionContextTask::taskNameForInstrumentation()

taskNameForInstrumentation() is a cause to define custom subclasses of
ExecutionContextTask and blocks removal of such custom subclasses.
This CL split it out to an argument of postTask() to enable further refactoring
of ExecutionContextTask subclasses.

BUG=478194
==========

to

==========
Remove ExecutionContextTask::taskNameForInstrumentation()

taskNameForInstrumentation() is a cause to define custom subclasses of
ExecutionContextTask and blocks removal of such custom subclasses.
This CL split it out to an argument of postTask() to enable further refactoring
of ExecutionContextTask subclasses.

BUG=478194
==========

[commit-bot: I haz the power, 2016-06-26 09:24:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-26 09:26:39]

Description was changed from

==========
Remove ExecutionContextTask::taskNameForInstrumentation()

taskNameForInstrumentation() is a cause to define custom subclasses of
ExecutionContextTask and blocks removal of such custom subclasses.
This CL split it out to an argument of postTask() to enable further refactoring
of ExecutionContextTask subclasses.

BUG=478194
==========

to

==========
Remove ExecutionContextTask::taskNameForInstrumentation()

taskNameForInstrumentation() is a cause to define custom subclasses of
ExecutionContextTask and blocks removal of such custom subclasses.
This CL split it out to an argument of postTask() to enable further refactoring
of ExecutionContextTask subclasses.

BUG=478194

Committed: https://crrev.com/d25ee900e7efe3ad6c677868ff42fbbfd92b8fae
Cr-Commit-Position: refs/heads/master@{#402079}
==========

[commit-bot: I haz the power, 2016-06-26 09:26:41]

Patchset 1 (id:??) landed as
https://crrev.com/d25ee900e7efe3ad6c677868ff42fbbfd92b8fae
Cr-Commit-Position: refs/heads/master@{#402079}