third_party/WebKit/Source/core/workers/WorkerThread.cpp - Issue 2098433002: Remove ExecutionContextTask::taskNameForInstrumentation()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.cpp

Issue 2098433002: Remove ExecutionContextTask::taskNameForInstrumentation() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerThread.h ('k') | third_party/WebKit/Source/core/workers/WorkletGlobalScope.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerThread.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.cpp b/third_party/WebKit/Source/core/workers/WorkerThread.cpp

index 07896af90af00783e7e8521ddab9811cb381677c..a1683f798cec3c8b19711aeab5910473549096d7 100644

--- a/third_party/WebKit/Source/core/workers/WorkerThread.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerThread.cpp

@@ -240,7 +240,7 @@ bool WorkerThread::isCurrentThread()

return m_started && workerBackingThread().backingThread().isCurrentThread();

}

-void WorkerThread::postTask(const WebTraceLocation& location, std::unique_ptr<ExecutionContextTask> task)

+void WorkerThread::postTask(const WebTraceLocation& location, std::unique_ptr<ExecutionContextTask> task, bool isInstrumented)

{

MutexLocker lock(m_threadStateMutex);

@@ -248,7 +248,6 @@ void WorkerThread::postTask(const WebTraceLocation& location, std::unique_ptr<Ex

return;

}

- bool isInstrumented = !task->taskNameForInstrumentation().isEmpty();

if (isInstrumented) {

DCHECK(isCurrentThread());

InspectorInstrumentation::asyncTaskScheduled(workerGlobalScope(), "Worker task", task.get());