Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2097253002: Remove ExecutionContextTask subclasses from DOMFileSystem (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
haraken, tzik
CC:
chromium-reviews, blink-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@ECT_TaskName
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ExecutionContextTask subclasses from DOMFileSystem This CL - makes scheduleCallback() to have SameThreadTask as an argument, - removes the null check of |callback| in scheduleCallback(), - removes the arguments handling codes and ExecutionContextTask subclasses around scheduleCallback(), and - makes the callsites of scheduleCallback() to - call createSameThreadTask() and do null check of callback, or - call reportError() instead. BUG=478194 Committed: https://crrev.com/a8a5e89eb2f7d8f4a6a12b8e8ab28ba7a54dcc35 Cr-Commit-Position: refs/heads/master@{#402129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -140 lines) Patch
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h View 3 chunks +5 lines, -120 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp View 2 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097253002/1
4 years, 5 months ago (2016-06-26 10:17:22 UTC) #2
hiroshige
tzik@, could you take a look as a modules/filesystem OWNER?
4 years, 5 months ago (2016-06-26 10:28:03 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-26 11:34:30 UTC) #8
tzik
lgtm
4 years, 5 months ago (2016-06-26 15:47:55 UTC) #9
haraken
LGTM, nice refactoring!
4 years, 5 months ago (2016-06-27 01:12:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097253002/1
4 years, 5 months ago (2016-06-27 07:18:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 07:21:27 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 07:22:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8a5e89eb2f7d8f4a6a12b8e8ab28ba7a54dcc35
Cr-Commit-Position: refs/heads/master@{#402129}

Powered by Google App Engine
This is Rietveld 408576698