Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1766903002:
Remove ExecutionContextTask subclasses that have task names (Closed)
|
Created:
4 years, 9 months ago by hiroshige Modified:
4 years, 5 months ago CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@Kuroneko_EC7_Document Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ExecutionContextTask subclasses that have task names
BUG=478194
Committed: https://crrev.com/c1f6fef2827f3d3269c2c103b23706d7260da9bd
Cr-Commit-Position: refs/heads/master@{#402137}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : Rebase #Patch Set 5 : Rebase #
Total comments: 3
Patch Set 6 : Add a comment #
Depends on Patchset: Messages
Total messages: 28 (15 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766903002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== temp BUG= ========== to ========== Remove ExecutionContextTask subclasses that have task names BUG= ==========
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766903002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove ExecutionContextTask subclasses that have task names BUG= ========== to ========== Remove ExecutionContextTask subclasses that have task names BUG=478194 ==========
hiroshige@chromium.org changed reviewers: + haraken@chromium.org, kinuko@chromium.org, tzik@chromium.org
hiroshige@chromium.org changed reviewers: - haraken@chromium.org, kinuko@chromium.org
PTAL. https://codereview.chromium.org/1766903002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp (right): https://codereview.chromium.org/1766903002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp:78: static void databaseCallbackHandleEvent(DatabaseCallback* callback, Database* database) This is just for ignoring DatabaseCallback::handleEvent()'s return value (int).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/1766903002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp (right): https://codereview.chromium.org/1766903002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp:78: static void databaseCallbackHandleEvent(DatabaseCallback* callback, Database* database) On 2016/06/26 10:42:37, hiroshige (slow) wrote: > This is just for ignoring DatabaseCallback::handleEvent()'s return value (int). Could you leave that as a comment?
hiroshige@chromium.org changed reviewers: + haraken@chromium.org
+haraken@, could you take a look as a core/ and modules/ OWNER? https://codereview.chromium.org/1766903002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp (right): https://codereview.chromium.org/1766903002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp:78: static void databaseCallbackHandleEvent(DatabaseCallback* callback, Database* database) On 2016/06/26 14:16:50, tzik wrote: > On 2016/06/26 10:42:37, hiroshige (slow) wrote: > > This is just for ignoring DatabaseCallback::handleEvent()'s return value > (int). > > Could you leave that as a comment? Done.
LGTM
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org Link to the patchset: https://codereview.chromium.org/1766903002/#ps100001 (title: "Add a comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove ExecutionContextTask subclasses that have task names BUG=478194 ========== to ========== Remove ExecutionContextTask subclasses that have task names BUG=478194 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Remove ExecutionContextTask subclasses that have task names BUG=478194 ========== to ========== Remove ExecutionContextTask subclasses that have task names BUG=478194 Committed: https://crrev.com/c1f6fef2827f3d3269c2c103b23706d7260da9bd Cr-Commit-Position: refs/heads/master@{#402137} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/c1f6fef2827f3d3269c2c103b23706d7260da9bd Cr-Commit-Position: refs/heads/master@{#402137} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
