Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2097023002: Reland [heap] Avoid the use of cells to point from code to new-space objects. (Closed)

Created:
4 years, 6 months ago by ahaas
Modified:
4 years, 5 months ago
Reviewers:
ulan
CC:
Hannes Payer (out of office), ulan, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland [heap] Avoid the use of cells to point from code to new-space objects. The reason for reverting is: This breaks gc-stress bot: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot Abortion of compaction could cause duplicate entries in the typed-old-to-new remembered set. These duplicates could cause a DCHECK to trigger which checks that slots recorded in the remembered set never point to to-space. This reland-CL allows duplicates in the remembered set by removing the DCHECK, and additionally clears entries in the remembered set if objects are moved. Original issue's description: Cells were needed originally because there was no typed remembered set to record direct pointers from code space to new space. A previous CL (https://codereview.chromium.org/2003553002/) already introduced the remembered set, this CL uses it. This CL * stores direct pointers in code objects, even if the target is in new space, * records the slot of the pointer in typed-old-to-new remembered set, * adds a list which stores weak code-to-new-space references, * adds a test to test-heap.cc for weak code-to-new-space references, * removes prints in tail-call-megatest.js Committed: https://crrev.com/5e058540192eaf95e8d1c2c3d0920219491cde15 Cr-Commit-Position: refs/heads/master@{#37325}

Patch Set 1 #

Patch Set 2 : Allow duplicate entries in the typed old-to-new remembered set, and clear the remembered set old-sp… #

Patch Set 3 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -173 lines) Patch
M src/arm/assembler-arm.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +1 line, -13 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M src/compiler.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M src/heap/heap.h View 3 chunks +10 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 7 chunks +37 lines, -37 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 11 chunks +58 lines, -25 lines 0 comments Download
M src/heap/remembered-set.h View 1 2 chunks +15 lines, -1 line 0 comments Download
M src/heap/remembered-set.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 3 chunks +1 line, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +3 lines, -25 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 1 chunk +1 line, -13 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 1 chunk +1 line, -13 lines 0 comments Download
M src/objects.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 1 chunk +19 lines, -5 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +13 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ahaas
4 years, 5 months ago (2016-06-28 11:35:55 UTC) #3
ulan
lgtm
4 years, 5 months ago (2016-06-28 12:10:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097023002/40001
4 years, 5 months ago (2016-06-28 12:30:40 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-28 12:34:33 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 12:36:42 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5e058540192eaf95e8d1c2c3d0920219491cde15
Cr-Commit-Position: refs/heads/master@{#37325}

Powered by Google App Engine
This is Rietveld 408576698