Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: src/arm/macro-assembler-arm.cc

Issue 2097023002: Reland [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/assembler-arm-inl.h ('k') | src/arm64/assembler-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/macro-assembler-arm.cc
diff --git a/src/arm/macro-assembler-arm.cc b/src/arm/macro-assembler-arm.cc
index 4feadb7350af05247cb001654c7e71590e8fc63b..8eb93a6b3332b3a2aa853146759b6e1d967d6daf 100644
--- a/src/arm/macro-assembler-arm.cc
+++ b/src/arm/macro-assembler-arm.cc
@@ -240,19 +240,7 @@ void MacroAssembler::Push(Handle<Object> handle) {
void MacroAssembler::Move(Register dst, Handle<Object> value) {
- AllowDeferredHandleDereference smi_check;
- if (value->IsSmi()) {
- mov(dst, Operand(value));
- } else {
- DCHECK(value->IsHeapObject());
- if (isolate()->heap()->InNewSpace(*value)) {
- Handle<Cell> cell = isolate()->factory()->NewCell(value);
- mov(dst, Operand(cell));
- ldr(dst, FieldMemOperand(dst, Cell::kValueOffset));
- } else {
- mov(dst, Operand(value));
- }
- }
+ mov(dst, Operand(value));
}
« no previous file with comments | « src/arm/assembler-arm-inl.h ('k') | src/arm64/assembler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698