Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: src/heap/remembered-set.h

Issue 2097023002: Reland [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/remembered-set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/remembered-set.h
diff --git a/src/heap/remembered-set.h b/src/heap/remembered-set.h
index 339748cbd723e5aedd36906e721924e98e54244c..8c5e7ffa01fb739358c59d6538a12eda80a7c5f6 100644
--- a/src/heap/remembered-set.h
+++ b/src/heap/remembered-set.h
@@ -120,7 +120,7 @@ class RememberedSet {
// Given a page and a range of typed slots in that page, this function removes
// the slots from the remembered set.
- static void RemoveRangeTyped(Page* page, Address start, Address end) {
+ static void RemoveRangeTyped(MemoryChunk* page, Address start, Address end) {
TypedSlotSet* slots = GetTypedSlotSet(page);
if (slots != nullptr) {
slots->Iterate([start, end](SlotType slot_type, Address host_addr,
@@ -345,6 +345,20 @@ class UpdateTypedSlotHelper {
}
};
+inline SlotType SlotTypeForRelocInfoMode(RelocInfo::Mode rmode) {
+ if (RelocInfo::IsCodeTarget(rmode)) {
+ return CODE_TARGET_SLOT;
+ } else if (RelocInfo::IsCell(rmode)) {
+ return CELL_TARGET_SLOT;
+ } else if (RelocInfo::IsEmbeddedObject(rmode)) {
+ return EMBEDDED_OBJECT_SLOT;
+ } else if (RelocInfo::IsDebugBreakSlot(rmode)) {
+ return DEBUG_TARGET_SLOT;
+ }
+ UNREACHABLE();
+ return NUMBER_OF_SLOT_TYPES;
+}
+
} // namespace internal
} // namespace v8
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/remembered-set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698