Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: net/quic/quic_stream_factory_test.cc

Issue 2096713002: Reduce SpdyHeaderBlock copies with move semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clear() does not work after all. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_network_transaction_unittest.cc ('k') | net/quic/test_tools/quic_test_packet_maker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory_test.cc
diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc
index b4e1e7a944b35de848b4525465bc0bc4877c8ce6..a68f4c646f9e71cd8f1d049f0fefc89ecbcf126f 100644
--- a/net/quic/quic_stream_factory_test.cc
+++ b/net/quic/quic_stream_factory_test.cc
@@ -5,6 +5,7 @@
#include "net/quic/quic_stream_factory.h"
#include <ostream>
+#include <utility>
#include "base/run_loop.h"
#include "base/strings/string_util.h"
@@ -457,7 +458,7 @@ class QuicStreamFactoryTestBase {
size_t spdy_headers_frame_len;
return client_maker_.MakeRequestHeadersPacket(
packet_number, stream_id, should_include_version, fin, priority,
- headers, &spdy_headers_frame_len);
+ std::move(headers), &spdy_headers_frame_len);
}
std::unique_ptr<QuicEncryptedPacket> ConstructOkResponsePacket(
@@ -468,8 +469,8 @@ class QuicStreamFactoryTestBase {
SpdyHeaderBlock headers = server_maker_.GetResponseHeaders("200 OK");
size_t spdy_headers_frame_len;
return server_maker_.MakeResponseHeadersPacket(
- packet_number, stream_id, should_include_version, fin, headers,
- &spdy_headers_frame_len);
+ packet_number, stream_id, should_include_version, fin,
+ std::move(headers), &spdy_headers_frame_len);
}
MockHostResolver host_resolver_;
« no previous file with comments | « net/quic/quic_network_transaction_unittest.cc ('k') | net/quic/test_tools/quic_test_packet_maker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698