Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: net/quic/test_tools/quic_test_packet_maker.h

Issue 2096713002: Reduce SpdyHeaderBlock copies with move semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clear() does not work after all. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | net/quic/test_tools/quic_test_packet_maker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/quic_test_packet_maker.h
diff --git a/net/quic/test_tools/quic_test_packet_maker.h b/net/quic/test_tools/quic_test_packet_maker.h
index 3f7bc740142655fee6758e5a50b0461c26404c97..f636d39e090d478025bd758ee42798e05248a6a9 100644
--- a/net/quic/test_tools/quic_test_packet_maker.h
+++ b/net/quic/test_tools/quic_test_packet_maker.h
@@ -114,7 +114,7 @@ class QuicTestPacketMaker {
bool should_include_version,
bool fin,
SpdyPriority priority,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
size_t* spdy_headers_frame_length,
const std::vector<std::string>& data_writes);
@@ -126,7 +126,7 @@ class QuicTestPacketMaker {
bool should_include_version,
bool fin,
SpdyPriority priority,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
size_t* spdy_headers_frame_length);
std::unique_ptr<QuicReceivedPacket> MakeRequestHeadersPacket(
@@ -135,7 +135,7 @@ class QuicTestPacketMaker {
bool should_include_version,
bool fin,
SpdyPriority priority,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
size_t* spdy_headers_frame_length,
QuicStreamOffset* offset);
@@ -147,7 +147,7 @@ class QuicTestPacketMaker {
bool should_include_version,
bool fin,
SpdyPriority priority,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
QuicStreamOffset* offset);
// If |spdy_headers_frame_length| is non-null, it will be set to the size of
@@ -157,7 +157,7 @@ class QuicTestPacketMaker {
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
size_t* spdy_headers_frame_length,
QuicStreamOffset* offset);
@@ -166,7 +166,7 @@ class QuicTestPacketMaker {
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
size_t* spdy_headers_frame_length);
// Convenience method for calling MakeResponseHeadersPacket with nullptr for
@@ -176,7 +176,7 @@ class QuicTestPacketMaker {
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
QuicStreamOffset* offset);
SpdyHeaderBlock GetRequestHeaders(const std::string& method,
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | net/quic/test_tools/quic_test_packet_maker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698