Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: net/quic/quic_network_transaction_unittest.cc

Issue 2096713002: Reduce SpdyHeaderBlock copies with move semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clear() does not work after all. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/quic_stream_factory_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_network_transaction_unittest.cc
diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc
index c32c0948fb561927808a6f85ffd9fa7971187df1..998a8f9839f0d19df7e42ebabef9a44e6328a26b 100644
--- a/net/quic/quic_network_transaction_unittest.cc
+++ b/net/quic/quic_network_transaction_unittest.cc
@@ -410,7 +410,7 @@ class QuicNetworkTransactionTest
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
QuicStreamOffset* offset) {
SpdyPriority priority =
ConvertRequestPriorityToQuicPriority(DEFAULT_PRIORITY);
@@ -424,7 +424,7 @@ class QuicNetworkTransactionTest
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
QuicStreamOffset* offset,
QuicTestPacketMaker* maker) {
SpdyPriority priority =
@@ -439,21 +439,21 @@ class QuicNetworkTransactionTest
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers) {
+ SpdyHeaderBlock headers) {
return ConstructClientRequestHeadersPacket(
- packet_number, stream_id, should_include_version, fin, headers, nullptr,
- &client_maker_);
+ packet_number, stream_id, should_include_version, fin,
+ std::move(headers), nullptr, &client_maker_);
}
std::unique_ptr<QuicEncryptedPacket> ConstructClientRequestHeadersPacket(
QuicPacketNumber packet_number,
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
QuicTestPacketMaker* maker) {
- return ConstructClientRequestHeadersPacket(packet_number, stream_id,
- should_include_version, fin,
- headers, nullptr, maker);
+ return ConstructClientRequestHeadersPacket(
+ packet_number, stream_id, should_include_version, fin,
+ std::move(headers), nullptr, maker);
}
std::unique_ptr<QuicEncryptedPacket> ConstructServerResponseHeadersPacket(
@@ -461,10 +461,10 @@ class QuicNetworkTransactionTest
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers) {
+ SpdyHeaderBlock headers) {
return ConstructServerResponseHeadersPacket(
- packet_number, stream_id, should_include_version, fin, headers, nullptr,
- &server_maker_);
+ packet_number, stream_id, should_include_version, fin,
+ std::move(headers), nullptr, &server_maker_);
}
std::unique_ptr<QuicEncryptedPacket> ConstructServerResponseHeadersPacket(
@@ -472,11 +472,11 @@ class QuicNetworkTransactionTest
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
QuicTestPacketMaker* maker) {
- return ConstructServerResponseHeadersPacket(packet_number, stream_id,
- should_include_version, fin,
- headers, nullptr, maker);
+ return ConstructServerResponseHeadersPacket(
+ packet_number, stream_id, should_include_version, fin,
+ std::move(headers), nullptr, maker);
}
std::unique_ptr<QuicEncryptedPacket> ConstructServerResponseHeadersPacket(
@@ -484,7 +484,7 @@ class QuicNetworkTransactionTest
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
QuicStreamOffset* offset) {
return server_maker_.MakeResponseHeadersPacketWithOffsetTracking(
packet_number, stream_id, should_include_version, fin, headers, offset);
@@ -495,7 +495,7 @@ class QuicNetworkTransactionTest
QuicStreamId stream_id,
bool should_include_version,
bool fin,
- const SpdyHeaderBlock& headers,
+ SpdyHeaderBlock headers,
QuicStreamOffset* offset,
QuicTestPacketMaker* maker) {
return server_maker_.MakeResponseHeadersPacketWithOffsetTracking(
@@ -2351,7 +2351,7 @@ class QuicNetworkTransactionWithDestinationTest
SpdyHeaderBlock headers(maker->GetRequestHeaders("GET", "https", "/"));
return maker->MakeRequestHeadersPacketWithOffsetTracking(
packet_number, stream_id, should_include_version, true, priority,
- headers, offset);
+ std::move(headers), offset);
}
std::unique_ptr<QuicEncryptedPacket> ConstructClientRequestHeadersPacket(
@@ -2370,7 +2370,7 @@ class QuicNetworkTransactionWithDestinationTest
QuicTestPacketMaker* maker) {
SpdyHeaderBlock headers(maker->GetResponseHeaders("200 OK"));
return maker->MakeResponseHeadersPacketWithOffsetTracking(
- packet_number, stream_id, false, false, headers, offset);
+ packet_number, stream_id, false, false, std::move(headers), offset);
}
std::unique_ptr<QuicEncryptedPacket> ConstructServerResponseHeadersPacket(
« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/quic_stream_factory_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698