Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: net/quic/quic_stream_factory_test.cc

Issue 2096713002: Reduce SpdyHeaderBlock copies with move semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clear() does not work after all. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_stream_factory.h" 5 #include "net/quic/quic_stream_factory.h"
6 6
7 #include <ostream> 7 #include <ostream>
8 #include <utility>
8 9
9 #include "base/run_loop.h" 10 #include "base/run_loop.h"
10 #include "base/strings/string_util.h" 11 #include "base/strings/string_util.h"
11 #include "base/threading/thread_task_runner_handle.h" 12 #include "base/threading/thread_task_runner_handle.h"
12 #include "net/cert/cert_verifier.h" 13 #include "net/cert/cert_verifier.h"
13 #include "net/cert/ct_policy_enforcer.h" 14 #include "net/cert/ct_policy_enforcer.h"
14 #include "net/cert/multi_log_ct_verifier.h" 15 #include "net/cert/multi_log_ct_verifier.h"
15 #include "net/dns/mock_host_resolver.h" 16 #include "net/dns/mock_host_resolver.h"
16 #include "net/http/http_response_headers.h" 17 #include "net/http/http_response_headers.h"
17 #include "net/http/http_response_info.h" 18 #include "net/http/http_response_info.h"
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 QuicStreamId stream_id, 451 QuicStreamId stream_id,
451 bool should_include_version, 452 bool should_include_version,
452 bool fin) { 453 bool fin) {
453 SpdyHeaderBlock headers = 454 SpdyHeaderBlock headers =
454 client_maker_.GetRequestHeaders("GET", "https", "/"); 455 client_maker_.GetRequestHeaders("GET", "https", "/");
455 SpdyPriority priority = 456 SpdyPriority priority =
456 ConvertRequestPriorityToQuicPriority(DEFAULT_PRIORITY); 457 ConvertRequestPriorityToQuicPriority(DEFAULT_PRIORITY);
457 size_t spdy_headers_frame_len; 458 size_t spdy_headers_frame_len;
458 return client_maker_.MakeRequestHeadersPacket( 459 return client_maker_.MakeRequestHeadersPacket(
459 packet_number, stream_id, should_include_version, fin, priority, 460 packet_number, stream_id, should_include_version, fin, priority,
460 headers, &spdy_headers_frame_len); 461 std::move(headers), &spdy_headers_frame_len);
461 } 462 }
462 463
463 std::unique_ptr<QuicEncryptedPacket> ConstructOkResponsePacket( 464 std::unique_ptr<QuicEncryptedPacket> ConstructOkResponsePacket(
464 QuicPacketNumber packet_number, 465 QuicPacketNumber packet_number,
465 QuicStreamId stream_id, 466 QuicStreamId stream_id,
466 bool should_include_version, 467 bool should_include_version,
467 bool fin) { 468 bool fin) {
468 SpdyHeaderBlock headers = server_maker_.GetResponseHeaders("200 OK"); 469 SpdyHeaderBlock headers = server_maker_.GetResponseHeaders("200 OK");
469 size_t spdy_headers_frame_len; 470 size_t spdy_headers_frame_len;
470 return server_maker_.MakeResponseHeadersPacket( 471 return server_maker_.MakeResponseHeadersPacket(
471 packet_number, stream_id, should_include_version, fin, headers, 472 packet_number, stream_id, should_include_version, fin,
472 &spdy_headers_frame_len); 473 std::move(headers), &spdy_headers_frame_len);
473 } 474 }
474 475
475 MockHostResolver host_resolver_; 476 MockHostResolver host_resolver_;
476 MockClientSocketFactory socket_factory_; 477 MockClientSocketFactory socket_factory_;
477 MockCryptoClientStreamFactory crypto_client_stream_factory_; 478 MockCryptoClientStreamFactory crypto_client_stream_factory_;
478 MockRandom random_generator_; 479 MockRandom random_generator_;
479 MockClock* clock_; // Owned by |factory_| once created. 480 MockClock* clock_; // Owned by |factory_| once created.
480 scoped_refptr<TestTaskRunner> runner_; 481 scoped_refptr<TestTaskRunner> runner_;
481 QuicVersion version_; 482 QuicVersion version_;
482 QuicTestPacketMaker client_maker_; 483 QuicTestPacketMaker client_maker_;
(...skipping 3847 matching lines...) Expand 10 before | Expand all | Expand 10 after
4330 EXPECT_NE(session1, session2); 4331 EXPECT_NE(session1, session2);
4331 4332
4332 EXPECT_EQ(QuicServerId(origin1_, privacy_mode_), session1->server_id()); 4333 EXPECT_EQ(QuicServerId(origin1_, privacy_mode_), session1->server_id());
4333 EXPECT_EQ(QuicServerId(origin2_, privacy_mode_), session2->server_id()); 4334 EXPECT_EQ(QuicServerId(origin2_, privacy_mode_), session2->server_id());
4334 4335
4335 EXPECT_TRUE(AllDataConsumed()); 4336 EXPECT_TRUE(AllDataConsumed());
4336 } 4337 }
4337 4338
4338 } // namespace test 4339 } // namespace test
4339 } // namespace net 4340 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_network_transaction_unittest.cc ('k') | net/quic/test_tools/quic_test_packet_maker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698