|
Make //crypto factories return std::unique_ptr<>s
Rather than make callers use base::WrapUnique or .reset(),
have //crypto functions that create new instances return them
in std::unique_ptr<>s
Also fixup NULL vs nullptr where it matters most, and remove
superflous .get() tests from the unique_ptr<>s
BUG=none
R=davidben@chromium.org
Committed: https://crrev.com/ffe5a13751bb5e90c02497f11f07f6ad6b1b7fd1
Cr-Commit-Position: refs/heads/master@{#402368}
Total comments: 9
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+285 lines, -315 lines) |
Patch |
|
M |
chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browsing_data/browsing_data_remover_unittest.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/login/profile_auth_data_unittest.cc
|
View
|
1
2
3
4
|
1 chunk |
+4 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/settings/token_encryptor.h
|
View
|
1
2
3
4
5
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/settings/token_encryptor.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/updater/local_extension_cache_unittest.cc
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/net/quota_policy_channel_id_store_unittest.cc
|
View
|
1
2
3
|
4 chunks |
+6 lines, -9 lines |
0 comments
|
Download
|
|
M |
components/crx_file/crx_file.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/os_crypt/os_crypt_mac.mm
|
View
|
1
2
3
4
|
1 chunk |
+4 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/browser/download/base_file.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
content/browser/download/download_item_impl.cc
|
View
|
1
2
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
crypto/ec_private_key.h
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
crypto/ec_private_key.cc
|
View
|
|
9 chunks |
+26 lines, -28 lines |
0 comments
|
Download
|
|
M |
crypto/ec_private_key_unittest.cc
|
View
|
|
8 chunks |
+12 lines, -12 lines |
0 comments
|
Download
|
|
M |
crypto/ec_signature_creator.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
crypto/ec_signature_creator.cc
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
crypto/ec_signature_creator_impl.cc
|
View
|
1
|
2 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
crypto/encryptor.cc
|
View
|
|
4 chunks |
+8 lines, -9 lines |
0 comments
|
Download
|
|
M |
crypto/hmac.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
crypto/hmac_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
crypto/mock_apple_keychain.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
crypto/nss_util.cc
|
View
|
|
13 chunks |
+21 lines, -21 lines |
0 comments
|
Download
|
|
M |
crypto/nss_util_internal.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
crypto/secure_hash.h
|
View
|
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
crypto/secure_hash.cc
|
View
|
|
3 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
crypto/signature_creator.h
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
crypto/signature_creator.cc
|
View
|
1
2
|
6 chunks |
+15 lines, -18 lines |
0 comments
|
Download
|
|
M |
crypto/signature_verifier.cc
|
View
|
|
3 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
crypto/symmetric_key.h
|
View
|
|
3 chunks |
+14 lines, -9 lines |
0 comments
|
Download
|
|
M |
crypto/symmetric_key.cc
|
View
|
1
2
|
6 chunks |
+22 lines, -18 lines |
0 comments
|
Download
|
|
M |
crypto/symmetric_key_unittest.cc
|
View
|
|
5 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
crypto/wincrypt_shim.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
extensions/browser/content_verify_job.cc
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
media/cast/common/transport_encryption_handler.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
media/cdm/aes_decryptor.cc
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
net/extras/sqlite/sqlite_channel_id_store_unittest.cc
|
View
|
1
2
|
5 chunks |
+6 lines, -9 lines |
0 comments
|
Download
|
|
M |
net/spdy/spdy_test_util_common.h
|
View
|
1
2
3
4
5
6
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
net/spdy/spdy_test_util_common.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
net/ssl/channel_id_service.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
net/ssl/channel_id_service_unittest.cc
|
View
|
1
2
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
net/ssl/channel_id_store.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/ssl/default_channel_id_store.cc
|
View
|
1
2
3
4
5
6
7
|
6 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
net/ssl/default_channel_id_store_unittest.cc
|
View
|
|
13 chunks |
+35 lines, -58 lines |
0 comments
|
Download
|
|
M |
sync/util/nigori.cc
|
View
|
|
1 chunk |
+20 lines, -19 lines |
0 comments
|
Download
|
Total messages: 52 (25 generated)
|