content/browser/download/base_file.cc - Issue 2095523002: Make //crypto factories return std::unique_ptr<>s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/base_file.cc

Issue 2095523002: Make //crypto factories return std::unique_ptr<>s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: I'm blind Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/base_file.cc

diff --git a/content/browser/download/base_file.cc b/content/browser/download/base_file.cc

index e34970f786875d077c112a20aaf70f03cff69dd8..735793270ff8a18994792f7b0355f7ab5e140ee0 100644

--- a/content/browser/download/base_file.cc

+++ b/content/browser/download/base_file.cc

@@ -208,7 +208,7 @@ std::string BaseFile::DebugString() const {

DownloadInterruptReason BaseFile::CalculatePartialHash(

const std::string& hash_to_expect) {

- secure_hash_.reset(crypto::SecureHash::Create(crypto::SecureHash::SHA256));

+ secure_hash_ = crypto::SecureHash::Create(crypto::SecureHash::SHA256);

if (bytes_so_far_ == 0)

return DOWNLOAD_INTERRUPT_REASON_NONE;

« no previous file with comments | « components/os_crypt/os_crypt_mac.mm ('k') | content/browser/download/download_item_impl.cc » ('j') | no next file with comments »