content/browser/download/download_item_impl.cc - Issue 2095523002: Make //crypto factories return std::unique_ptr<>s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.cc

Issue 2095523002: Make //crypto factories return std::unique_ptr<>s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: I'm blind Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_item_impl.cc

diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc

index 972a9570e1b384e7bdeb50f2f215f912dc4b439a..be68b07963be50a400d3e0fab3e445127ce1b8c0 100644

--- a/content/browser/download/download_item_impl.cc

+++ b/content/browser/download/download_item_impl.cc

@@ -31,7 +31,6 @@

#include "base/format_macros.h"

#include "base/guid.h"

#include "base/logging.h"

-#include "base/memory/ptr_util.h"

#include "base/metrics/histogram.h"

#include "base/stl_util.h"

#include "base/strings/string_util.h"

@@ -1175,9 +1174,9 @@ void DownloadItemImpl::Start(

int64_t offset = new_create_info.save_info->offset;

std::unique_ptr<crypto::SecureHash> hash_state =

- base::WrapUnique(new_create_info.save_info->hash_state

- ? new_create_info.save_info->hash_state->Clone()

- : nullptr);

+ new_create_info.save_info->hash_state

+ ? new_create_info.save_info->hash_state->Clone()

+ : nullptr;

// Interrupted downloads also need a target path.

if (target_path_.empty()) {

« no previous file with comments | « content/browser/download/base_file.cc ('k') | crypto/ec_private_key.h » ('j') | no next file with comments »