Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: net/ssl/channel_id_service.cc

Issue 2095523002: Make //crypto factories return std::unique_ptr<>s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: I'm blind Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_test_util_common.cc ('k') | net/ssl/channel_id_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/channel_id_service.cc
diff --git a/net/ssl/channel_id_service.cc b/net/ssl/channel_id_service.cc
index 8c0ace195efa37a2377de4c146027c9acae59700..500a7400a4fc9318bfaa65255b4da276b4c635fa 100644
--- a/net/ssl/channel_id_service.cc
+++ b/net/ssl/channel_id_service.cc
@@ -192,7 +192,7 @@ class ChannelIDServiceJob {
i != requests.end(); i++) {
std::unique_ptr<crypto::ECPrivateKey> key_copy;
if (key)
- key_copy.reset(key->Copy());
+ key_copy = key->Copy();
(*i)->Post(error, std::move(key_copy));
}
}
@@ -439,7 +439,7 @@ void ChannelIDService::GeneratedChannelID(
std::unique_ptr<crypto::ECPrivateKey> key;
if (error == OK) {
- key.reset(channel_id->key()->Copy());
+ key = channel_id->key()->Copy();
channel_id_store_->SetChannelID(std::move(channel_id));
}
HandleResult(error, server_identifier, std::move(key));
« no previous file with comments | « net/spdy/spdy_test_util_common.cc ('k') | net/ssl/channel_id_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698