Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 2095183002: Add a GL cap for instanced rendering to floating point (Closed)

Created:
4 years, 6 months ago by csmartdalton
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a GL cap for instanced rendering to floating point We have observed on OS X that instanced draws don't always behave correctly when the framebuffer is floating point. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095183002 Committed: https://skia.googlesource.com/skia/+/c411f2d963cdee3a934c9ff65b0728d2b927586a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M include/gpu/GrTypes.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 3 chunks +10 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 6 months ago (2016-06-25 03:53:15 UTC) #3
bsalomon
lgtm
4 years, 5 months ago (2016-06-27 13:52:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095183002/1
4 years, 5 months ago (2016-06-27 16:07:37 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 16:29:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c411f2d963cdee3a934c9ff65b0728d2b927586a

Powered by Google App Engine
This is Rietveld 408576698