wayland-protocols: Add gaming-input-unstable-v1 protocol

wayland-protocols: Add gaming-input-unstable-v1 protocol

This protocol allows the wayland server to notify the client of
connected gamepads and their state.
The protocol does not support axis mapping but assumes the use of the
'Standard Gamepad' as defined by the W3C gamepad API.

BUG=620977
Committed: https://crrev.com/350078de44e0def33380d1074446408f6ebe6967
Cr-Commit-Position: refs/heads/master@{#405238}

[denniskempin (chromium), 2016-06-23 21:16:50]

denniskempin@chromium.org changed reviewers:
+ denniskempin@chromium.org, reveman@chromium.org

[reveman, 2016-06-23 21:34:20]

https://codereview.chromium.org/2093803002/diff/1/third_party/wayland-protoco...
File third_party/wayland-protocols/unstable/gamepads/README (right):

https://codereview.chromium.org/2093803002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/gamepads/README:4: Dennis Kempin
<denniskempin@google.com>
@chromium.org?

https://codereview.chromium.org/2093803002/diff/1/third_party/wayland-protoco...
File third_party/wayland-protocols/unstable/gamepads/gamepads-unstable-v1.xml
(right):

https://codereview.chromium.org/2093803002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/gamepads/gamepads-unstable-v1.xml:27:
<interface name="zwp_gamepads_v1" version="1">
is this a global? it would be nice if this was consistent with other input
devices and the client could ask for the gamepad interface for a seat. is that
possible?

https://codereview.chromium.org/2093803002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/gamepads/gamepads-unstable-v1.xml:102: 
nit: kill blank line

[denniskempin, 2016-06-28 20:15:33]

https://codereview.chromium.org/2093803002/diff/1/third_party/wayland-protoco...
File third_party/wayland-protocols/unstable/gamepads/README (right):

https://codereview.chromium.org/2093803002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/gamepads/README:4: Dennis Kempin
<denniskempin@google.com>
On 2016/06/23 21:34:19, reveman wrote:
> @chromium.org?

Done.

https://codereview.chromium.org/2093803002/diff/1/third_party/wayland-protoco...
File third_party/wayland-protocols/unstable/gamepads/gamepads-unstable-v1.xml
(right):

https://codereview.chromium.org/2093803002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/gamepads/gamepads-unstable-v1.xml:27:
<interface name="zwp_gamepads_v1" version="1">
On 2016/06/23 21:34:20, reveman wrote:
> is this a global? it would be nice if this was consistent with other input
> devices and the client could ask for the gamepad interface for a seat. is that
> possible?

Done.

https://codereview.chromium.org/2093803002/diff/1/third_party/wayland-protoco...
third_party/wayland-protocols/unstable/gamepads/gamepads-unstable-v1.xml:102: 
On 2016/06/23 21:34:19, reveman wrote:
> nit: kill blank line

Done.

[reveman, 2016-06-29 22:37:50]

https://codereview.chromium.org/2093803002/diff/120001/third_party/wayland-pr...
File
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml
(right):

https://codereview.chromium.org/2093803002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml:52:
<interface name="zwp_gamepad_v1" version="1">
do we need enter/leave events to notify the client when this seat's gamepad
focus is on a certain surface and the state of all buttons?

https://codereview.chromium.org/2093803002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml:107:
<arg name="time" type="uint" summary="timestamp with millisecond granularity"/>
should we have a serial here in case we ever want these events to be able to be
used for window manager interaction?

<arg name="serial" type="uint" summary="serial number of the button event"/>

https://codereview.chromium.org/2093803002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml:122:
<request name="destroy" type="destructor">
nit: move destructor to top for consistency with other interfaces

[denniskempin, 2016-07-12 20:15:24]

https://codereview.chromium.org/2093803002/diff/120001/third_party/wayland-pr...
File
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml
(right):

https://codereview.chromium.org/2093803002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml:52:
<interface name="zwp_gamepad_v1" version="1">
On 2016/06/29 22:37:50, reveman wrote:
> do we need enter/leave events to notify the client when this seat's gamepad
> focus is on a certain surface and the state of all buttons?

as discussed, not with this version of the protocol. Potentially for later
versions.

https://codereview.chromium.org/2093803002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml:107:
<arg name="time" type="uint" summary="timestamp with millisecond granularity"/>
On 2016/06/29 22:37:50, reveman wrote:
> should we have a serial here in case we ever want these events to be able to
be
> used for window manager interaction?
> 
> <arg name="serial" type="uint" summary="serial number of the button event"/>

Also not exactly feasible with the current protocol since buttons can be analog.
Might be possible by splitting button events into logical 0->1 button changes
and analog changes.

https://codereview.chromium.org/2093803002/diff/120001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml:122:
<request name="destroy" type="destructor">
On 2016/06/29 22:37:50, reveman wrote:
> nit: move destructor to top for consistency with other interfaces

Done.

[denniskempin, 2016-07-12 20:56:10]

Description was changed from

==========
wayland-protocols: Add gamepads-unstable-v1 protocol

This protocol allows the wayland server to notify the client of
connected gamepads and their state.
The protocol does not support axis mapping but assumes the use of the
'Standard Gamepad' as defined by the W3C gamepad API.

BUG=620977
==========

to

==========
wayland-protocols: Add gaming-input-unstable-v1 protocol

This protocol allows the wayland server to notify the client of
connected gamepads and their state.
The protocol does not support axis mapping but assumes the use of the
'Standard Gamepad' as defined by the W3C gamepad API.

BUG=620977
==========

[reveman, 2016-07-13 10:11:03]

lgtm % nits

https://codereview.chromium.org/2093803002/diff/140001/third_party/wayland-pr...
File third_party/wayland-protocols/protocol/gaming-input-protocol.c (right):

https://codereview.chromium.org/2093803002/diff/140001/third_party/wayland-pr...
third_party/wayland-protocols/protocol/gaming-input-protocol.c:1: /*
nit: please use wayland-scanner 1.11.0 to generate these file. you can find this
version of wayland scanner in third_party/wayland/src

https://codereview.chromium.org/2093803002/diff/140001/third_party/wayland-pr...
File
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml
(right):

https://codereview.chromium.org/2093803002/diff/140001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml:29:
A global uinterface to provide gaming input devices for a given seat.
nit: s/uinterface/interface/

[denniskempin, 2016-07-13 15:48:22]

https://codereview.chromium.org/2093803002/diff/140001/third_party/wayland-pr...
File third_party/wayland-protocols/protocol/gaming-input-protocol.c (right):

https://codereview.chromium.org/2093803002/diff/140001/third_party/wayland-pr...
third_party/wayland-protocols/protocol/gaming-input-protocol.c:1: /*
On 2016/07/13 10:11:03, reveman wrote:
> nit: please use wayland-scanner 1.11.0 to generate these file. you can find
this
> version of wayland scanner in third_party/wayland/src

Done.

https://codereview.chromium.org/2093803002/diff/140001/third_party/wayland-pr...
File
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml
(right):

https://codereview.chromium.org/2093803002/diff/140001/third_party/wayland-pr...
third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml:29:
A global uinterface to provide gaming input devices for a given seat.
On 2016/07/13 10:11:03, reveman wrote:
> nit: s/uinterface/interface/

Done.

[denniskempin, 2016-07-13 15:50:49]

The CQ bit was checked by denniskempin@google.com

[denniskempin, 2016-07-13 15:50:50]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2093803002/#ps160001
(title: "fixed nit, regenerated")

[commit-bot: I haz the power, 2016-07-13 15:51:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 16:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 16:51:33]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[denniskempin, 2016-07-13 17:26:41]

The CQ bit was checked by denniskempin@google.com

[commit-bot: I haz the power, 2016-07-13 17:27:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[denniskempin, 2016-07-13 17:27:14]

must be a flake... this code isn't even compiled anywhere, so it should't be
able to cause a unit test failure on android..

[commit-bot: I haz the power, 2016-07-13 18:42:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:42:38]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[denniskempin, 2016-07-13 18:45:08]

The CQ bit was checked by denniskempin@google.com

[commit-bot: I haz the power, 2016-07-13 18:45:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:52:28]

Description was changed from

==========
wayland-protocols: Add gaming-input-unstable-v1 protocol

This protocol allows the wayland server to notify the client of
connected gamepads and their state.
The protocol does not support axis mapping but assumes the use of the
'Standard Gamepad' as defined by the W3C gamepad API.

BUG=620977
==========

to

==========
wayland-protocols: Add gaming-input-unstable-v1 protocol

This protocol allows the wayland server to notify the client of
connected gamepads and their state.
The protocol does not support axis mapping but assumes the use of the
'Standard Gamepad' as defined by the W3C gamepad API.

BUG=620977
==========

[commit-bot: I haz the power, 2016-07-13 19:52:29]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-13 19:53:47]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 19:55:11]

Description was changed from

==========
wayland-protocols: Add gaming-input-unstable-v1 protocol

This protocol allows the wayland server to notify the client of
connected gamepads and their state.
The protocol does not support axis mapping but assumes the use of the
'Standard Gamepad' as defined by the W3C gamepad API.

BUG=620977
==========

to

==========
wayland-protocols: Add gaming-input-unstable-v1 protocol

This protocol allows the wayland server to notify the client of
connected gamepads and their state.
The protocol does not support axis mapping but assumes the use of the
'Standard Gamepad' as defined by the W3C gamepad API.

BUG=620977

Committed: https://crrev.com/350078de44e0def33380d1074446408f6ebe6967
Cr-Commit-Position: refs/heads/master@{#405238}
==========

[commit-bot: I haz the power, 2016-07-13 19:55:13]

Patchset 9 (id:??) landed as
https://crrev.com/350078de44e0def33380d1074446408f6ebe6967
Cr-Commit-Position: refs/heads/master@{#405238}