[builtins] New frame type for exits to C++ builtins

[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel;tryserver.v8:v8_linux_nosnap_dbg

Committed: https://crrev.com/3c60c6b105f39344f93a8407f41534e5e60cf19a
Committed: https://crrev.com/5febc27b5d17f14908d5e3c225bdb9b8a6b2df9a
Cr-Original-Commit-Position: refs/heads/master@{#37384}
Cr-Commit-Position: refs/heads/master@{#37416}

[jgruber, 2016-06-24 06:55:12]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 06:55:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2090723005/1

[Benedikt Meurer, 2016-06-24 07:30:30]

Description was changed from

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
==========

to

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-24 08:16:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 08:16:55]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[Benedikt Meurer, 2016-06-27 06:58:24]

LGTM.

[Yang, 2016-06-27 08:30:02]

lgtm.

https://codereview.chromium.org/2090723005/diff/1/src/builtins.h
File src/builtins.h (right):

https://codereview.chromium.org/2090723005/diff/1/src/builtins.h#newcode42
src/builtins.h:42: V(Illegal, true)                              \
Might be nicer to have an enum instead of a boolean, like we have for
BUILTIN_LIST_A.

Or create a new macro list for these three API builtins.

[jgruber, 2016-06-27 10:54:12]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 10:54:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 10:56:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 10:56:48]

Dry run: Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/9506)

[jgruber, 2016-06-27 11:01:17]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 11:01:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 11:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 11:03:49]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[jgruber, 2016-06-27 11:08:48]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 11:08:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 12:12:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 12:12:29]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[jgruber, 2016-06-29 09:05:47]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 09:05:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 10:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 10:43:56]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-06-29 11:05:30]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-06-29 11:05:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2090723005/#ps80001
(title: "Revert changes to StackTraceFrameIterator")

[commit-bot: I haz the power, 2016-06-29 11:05:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 11:09:26]

Description was changed from

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

to

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-29 11:09:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-29 11:10:41]

Description was changed from

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

to

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3c60c6b105f39344f93a8407f41534e5e60cf19a
Cr-Commit-Position: refs/heads/master@{#37384}
==========

[commit-bot: I haz the power, 2016-06-29 11:10:43]

Patchset 5 (id:??) landed as
https://crrev.com/3c60c6b105f39344f93a8407f41534e5e60cf19a
Cr-Commit-Position: refs/heads/master@{#37384}

[Benedikt Meurer, 2016-06-29 12:36:37]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2106113002/ by bmeurer@chromium.org.

The reason for reverting is: Looks like this breaks on nosnap:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20....

[Yang, 2016-06-29 13:24:30]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2109603004/ by yangguo@chromium.org.

The reason for reverting is: Speculative revert for this failure:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2....

[jgruber, 2016-06-29 15:05:49]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[jgruber, 2016-06-29 15:07:35]

Description was changed from

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3c60c6b105f39344f93a8407f41534e5e60cf19a
Cr-Commit-Position: refs/heads/master@{#37384}
==========

to

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel;tryserver.v8:v8_linux_nosnap_dbg

Committed: https://crrev.com/3c60c6b105f39344f93a8407f41534e5e60cf19a
Cr-Commit-Position: refs/heads/master@{#37384}
==========

[commit-bot: I haz the power, 2016-06-29 15:07:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-06-29 15:08:38]

Fixed failing DCHECK, PTAL.

[commit-bot: I haz the power, 2016-06-29 16:28:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 16:28:33]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-06-29 18:18:24]

lgtm

[jgruber, 2016-06-30 06:53:08]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-06-30 06:53:09]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2090723005/#ps100001
(title: "Add missing condition in SafeStackFrameIter::frame()")

[commit-bot: I haz the power, 2016-06-30 06:53:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 06:55:30]

Description was changed from

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel;tryserver.v8:v8_linux_nosnap_dbg

Committed: https://crrev.com/3c60c6b105f39344f93a8407f41534e5e60cf19a
Cr-Commit-Position: refs/heads/master@{#37384}
==========

to

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel;tryserver.v8:v8_linux_nosnap_dbg

Committed: https://crrev.com/3c60c6b105f39344f93a8407f41534e5e60cf19a
Cr-Commit-Position: refs/heads/master@{#37384}
==========

[commit-bot: I haz the power, 2016-06-30 06:55:32]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-30 06:58:34]

Description was changed from

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel;tryserver.v8:v8_linux_nosnap_dbg

Committed: https://crrev.com/3c60c6b105f39344f93a8407f41534e5e60cf19a
Cr-Commit-Position: refs/heads/master@{#37384}
==========

to

==========
[builtins] New frame type for exits to C++ builtins

Prior to this commit, calls to C++ builtins created standard exit
frames, which are skipped when constructing JS stack traces. In order to
show these calls on traces, we introduce a new builtin exit frame type.

Builtin exit frames contain target and new.target on the stack and are
not skipped during stack trace construction.

BUG=v8:4815
R=bmeurer@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel;tryserver.v8:v8_linux_nosnap_dbg

Committed: https://crrev.com/3c60c6b105f39344f93a8407f41534e5e60cf19a
Committed: https://crrev.com/5febc27b5d17f14908d5e3c225bdb9b8a6b2df9a
Cr-Original-Commit-Position: refs/heads/master@{#37384}
Cr-Commit-Position: refs/heads/master@{#37416}
==========

[commit-bot: I haz the power, 2016-06-30 06:58:35]

Patchset 6 (id:??) landed as
https://crrev.com/5febc27b5d17f14908d5e3c225bdb9b8a6b2df9a
Cr-Commit-Position: refs/heads/master@{#37416}