src/arm64/code-stubs-arm64.cc - Issue 2090723005: [builtins] New frame type for exits to C++ builtins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/code-stubs-arm64.cc

Issue 2090723005: [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add missing condition in SafeStackFrameIter::frame() Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/code-stubs-arm64.cc

diff --git a/src/arm64/code-stubs-arm64.cc b/src/arm64/code-stubs-arm64.cc

index 43bb45956d4fc0d1e91f398aaca5e001e4392ade..be5f30eaa45d1d9dbb7998ee2e3721e19df5ef06 100644

--- a/src/arm64/code-stubs-arm64.cc

+++ b/src/arm64/code-stubs-arm64.cc

@@ -925,7 +925,9 @@ void CEntryStub::Generate(MacroAssembler* masm) {

int extra_stack_space = 3 + (result_size() <= 2 ? 0 : result_size());

// Enter the exit frame.

FrameScope scope(masm, StackFrame::MANUAL);

- __ EnterExitFrame(save_doubles(), x10, extra_stack_space);

+ __ EnterExitFrame(

+ save_doubles(), x10, extra_stack_space,

+ is_builtin_exit() ? StackFrame::BUILTIN_EXIT : StackFrame::EXIT);

DCHECK(csp.Is(__ StackPointer()));

// Poke callee-saved registers into reserved space.

« no previous file with comments | « src/arm64/builtins-arm64.cc ('k') | src/arm64/macro-assembler-arm64.h » ('j') | no next file with comments »