Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2109603004: Revert of [builtins] New frame type for exits to C++ builtins (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, Yang, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] New frame type for exits to C++ builtins (patchset #5 id:80001 of https://codereview.chromium.org/2090723005/ ) Reason for revert: Speculative revert for this failure: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/7626 Original issue's description: > [builtins] New frame type for exits to C++ builtins > > Prior to this commit, calls to C++ builtins created standard exit > frames, which are skipped when constructing JS stack traces. In order to > show these calls on traces, we introduce a new builtin exit frame type. > > Builtin exit frames contain target and new.target on the stack and are > not skipped during stack trace construction. > > BUG=v8:4815 > R=bmeurer@chromium.org, yangguo@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/3c60c6b105f39344f93a8407f41534e5e60cf19a > Cr-Commit-Position: refs/heads/master@{#37384} TBR=bmeurer@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -432 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M src/builtins.h View 5 chunks +145 lines, -148 lines 0 comments Download
M src/builtins.cc View 9 chunks +5 lines, -12 lines 0 comments Download
M src/code-stubs.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/counters.h View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/external-reference-table.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/frames.h View 5 chunks +1 line, -33 lines 0 comments Download
M src/frames.cc View 6 chunks +2 lines, -27 lines 0 comments Download
M src/frames-inl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M src/isolate.cc View 3 chunks +0 lines, -32 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M src/profiler/tick-sample.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 3 chunks +3 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 5 chunks +11 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/message/paren_in_arg_string.out View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-4815.js View 2 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Yang
Created Revert of [builtins] New frame type for exits to C++ builtins
4 years, 5 months ago (2016-06-29 13:24:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109603004/1
4 years, 5 months ago (2016-06-29 13:24:39 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 13:25:02 UTC) #5
Failed to apply patch for src/external-reference-table.cc:
While running git apply --index -3 -p1;
  error: patch failed: src/external-reference-table.cc:236
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: src/external-reference-table.cc: patch does not apply

Patch:       src/external-reference-table.cc
Index: src/external-reference-table.cc
diff --git a/src/external-reference-table.cc b/src/external-reference-table.cc
index
91fc5315861c0f2a7016a63f66aae9e69b4f665a..92a7c771bd5478e1dba9c1474ca33fb5c8db13a3
100644
--- a/src/external-reference-table.cc
+++ b/src/external-reference-table.cc
@@ -236,7 +236,7 @@
   };
 
   static const RefTableEntry c_builtins[] = {
-#define DEF_ENTRY_C(name, ignore) {Builtins::c_##name, "Builtins::" #name},
+#define DEF_ENTRY_C(name) {Builtins::c_##name, "Builtins::" #name},
       BUILTIN_LIST_C(DEF_ENTRY_C)
 #undef DEF_ENTRY_C
   };
@@ -248,7 +248,7 @@
   }
 
   static const RefTableEntry builtins[] = {
-#define DEF_ENTRY_C(name, ignore) {Builtins::k##name, "Builtins::" #name},
+#define DEF_ENTRY_C(name) {Builtins::k##name, "Builtins::" #name},
 #define DEF_ENTRY_A(name, i1, i2) {Builtins::k##name, "Builtins::" #name},
       BUILTIN_LIST_C(DEF_ENTRY_C) BUILTIN_LIST_A(DEF_ENTRY_A)
           BUILTIN_LIST_DEBUG_A(DEF_ENTRY_A)

Powered by Google App Engine
This is Rietveld 408576698